Fix late comment review for #102038 #102869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-core Author: Giuseppe Rossini (giuseros) ChangesFull diff: https://github.com/llvm/llvm-project/pull/102869.diff 1 Files Affected:
diff --git a/mlir/lib/Transforms/Utils/RegionUtils.cpp b/mlir/lib/Transforms/Utils/RegionUtils.cpp
index dd75e283a36b8d..3c7523827699c8 100644
--- a/mlir/lib/Transforms/Utils/RegionUtils.cpp
+++ b/mlir/lib/Transforms/Utils/RegionUtils.cpp
@@ -1012,7 +1012,8 @@ static LogicalResult dropRedundantArguments(RewriterBase &rewriter,
// Add any nested regions to the worklist.
for (Block &block : *region) {
- anyChanged = succeeded(dropRedundantArguments(rewriter, block));
+ anyChanged =
+ succeeded(dropRedundantArguments(rewriter, block)) || anyChanged;
for (Operation &op : block)
for (Region &nestedRegion : op.getRegions())
|
|
@llvm/pr-subscribers-mlir Author: Giuseppe Rossini (giuseros) ChangesFull diff: https://github.com/llvm/llvm-project/pull/102869.diff 1 Files Affected:
diff --git a/mlir/lib/Transforms/Utils/RegionUtils.cpp b/mlir/lib/Transforms/Utils/RegionUtils.cpp
index dd75e283a36b8d..3c7523827699c8 100644
--- a/mlir/lib/Transforms/Utils/RegionUtils.cpp
+++ b/mlir/lib/Transforms/Utils/RegionUtils.cpp
@@ -1012,7 +1012,8 @@ static LogicalResult dropRedundantArguments(RewriterBase &rewriter,
// Add any nested regions to the worklist.
for (Block &block : *region) {
- anyChanged = succeeded(dropRedundantArguments(rewriter, block));
+ anyChanged =
+ succeeded(dropRedundantArguments(rewriter, block)) || anyChanged;
for (Operation &op : block)
for (Region &nestedRegion : op.getRegions())
|
bwendling
pushed a commit
to bwendling/llvm-project
that referenced
this pull request
Aug 15, 2024
antiagainst
added a commit
to triton-lang/triton
that referenced
this pull request
Aug 31, 2024
This contains the two commit we want to have for AMD backend: * llvm/llvm-project#102869 * llvm/llvm-project#104598 This needs to update `visitOperation` signature following llvm/llvm-project@15e915a44f Also added `mlir::LLVM::registerInlinerInterface` to address LLVM ERROR: checking for an interface (`mlir::DialectInlinerInterface`) that was promised by dialect 'llvm' but never implemented.
antiagainst
added a commit
to antiagainst/triton
that referenced
this pull request
Aug 31, 2024
This contains the two commit we want to have for AMD backend: * llvm/llvm-project#102869 * llvm/llvm-project#104598 This needs to update `visitOperation` signature following llvm/llvm-project@15e915a44f Also added `mlir::LLVM::registerInlinerInterface` to address LLVM ERROR: checking for an interface (`mlir::DialectInlinerInterface`) that was promised by dialect 'llvm' but never implemented.
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
This contains the two commit we want to have for AMD backend: * llvm/llvm-project#102869 * llvm/llvm-project#104598 This needs to update `visitOperation` signature following llvm/llvm-project@15e915a44f Also added `mlir::LLVM::registerInlinerInterface` to address LLVM ERROR: checking for an interface (`mlir::DialectInlinerInterface`) that was promised by dialect 'llvm' but never implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.