[libc++][C++26] constexpr std::stable_sort (part of P2562)
#105379
+243
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I'm trying a different approach in #100914 - which should allow adding |
| @@ -67,7 +67,7 @@ template <class _AlgPolicy, | |||
| class _InputIterator2, | |||
| class _Sent2, | |||
| class _OutputIterator> | |||
| _LIBCPP_HIDE_FROM_ABI void __half_inplace_merge( | |||
| _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX23 void __half_inplace_merge( | |||
There was a problem hiding this comment.
Why not _LIBCPP_CONSTEXPR_SINCE_CXX26 (ditto below)?
PaulXiCao
force-pushed
the
constexpr_stable_sort
branch
from
acaea71
to
55c19d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of P2562 / C++26 std::stable_sort is constexpr. The paper is available here: https://wg21.link/p2562 .
It contains other functions that should be made constexpr as well. (I might work on them later on. Either appending them to this pr or creating separate ones.)
Regarding testing: I refactored the original tests, used some of them for testing the constexpr functionality, and also created tests for the "stable" part of
std::stable_sort(i.e. search forstability_testin the test file).