Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC][TableGen] Refactor StringToOffsetTable #105655

Merged
merged 1 commit into from
Aug 23, 2024
Merged

[NFC][TableGen] Refactor StringToOffsetTable #105655

merged 1 commit into from
Aug 23, 2024

Conversation

jurahul
Copy link
Contributor

@jurahul jurahul commented Aug 22, 2024

  • Make EmitString const by not mutating AggregateString.
  • Use C++17 structured bindings in GetOrAddStringOffset.
  • Use StringExtras version of isDigit instead of std::isdigit.

@jurahul jurahul marked this pull request as ready for review August 22, 2024 21:47
s-barannikov
s-barannikov approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@s-barannikov s-barannikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurahul
[NFC][TableGen] Refactor StringToOffsetTable
56d7f75 
- Make `EmitString` const by not mutating `AggregateString`.
- Use C++17 structured bindings in `GetOrAddStringOffset`.
- Use StringExtras version of isDigit instead of std::isdigit.
@jurahul jurahul force-pushed the string_to_offset_table_refactor branch from 0a01439 to 56d7f75 Compare August 23, 2024 10:53
@jurahul jurahul merged commit 04ab647 into llvm:main Aug 23, 2024
6 of 8 checks passed
@jurahul jurahul deleted the string_to_offset_table_refactor branch August 23, 2024 12:39
cjdb pushed a commit to cjdb/llvm-project that referenced this pull request Aug 23, 2024
@jurahul @cjdb
[NFC][TableGen] Refactor StringToOffsetTable (llvm#105655)
78b5887 
- Make `EmitString` const by not mutating `AggregateString`.
- Use C++17 structured bindings in `GetOrAddStringOffset`.
- Use StringExtras version of isDigit instead of std::isdigit.
5chmidti pushed a commit that referenced this pull request Aug 24, 2024
@jurahul @5chmidti
[NFC][TableGen] Refactor StringToOffsetTable (#105655)
2aef672 
- Make `EmitString` const by not mutating `AggregateString`.
- Use C++17 structured bindings in `GetOrAddStringOffset`.
- Use StringExtras version of isDigit instead of std::isdigit.
dmpolukhin pushed a commit to dmpolukhin/llvm-project that referenced this pull request Sep 2, 2024
@jurahul @dmpolukhin
[NFC][TableGen] Refactor StringToOffsetTable (llvm#105655)
ee90d2f 
- Make `EmitString` const by not mutating `AggregateString`.
- Use C++17 structured bindings in `GetOrAddStringOffset`.
- Use StringExtras version of isDigit instead of std::isdigit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-barannikov s-barannikov s-barannikov approved these changes

@kazutakahirata kazutakahirata Awaiting requested review from kazutakahirata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jurahul @s-barannikov