[llvm-c-test] Rename --test-dibuilder-debuginfo-format to --test-dibuilder
#105702
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
llvm-c-test-help
branch
2 times, most recently
from
ae1bd2a
to
ecccadb
Compare
|
@weliveindetail @OCHyams do you mind merging this one as well? |
OCHyams
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Thanks, good spot.
Looking at it though, I think the original name --test-dibuilder from before all the renaming makes the most sense in today's state. I think we probably should've restored that name in the patch you linked - I probably just missed that at the time.
Could I be cheeky and ask that you invert your patch; change the flag name to --test-dibuilder (keep the existing usage message) and update debug_info_new_format.ll to use that flag?
vadorovsky
force-pushed
the
llvm-c-test-help
branch
from
ecccadb
to
af06013
Compare
vadorovsky
changed the title
--test-dibuilder
vadorovsky
force-pushed
the
llvm-c-test-help
branch
from
af06013
to
8dcc50d
Compare
|
@OCHyams done |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
…ibuilder` The former name was introduced during the split between debug info intrinsic and `DbgRecord`. Before the split, it was named `--test-dibuilder`. However, the full migration to `DbgRecord` happened already and we have just one test suite related to building debug info using LLVM-C API. Therefore, it makes sense to rename it back to `--test-dibuilder`.
vadorovsky
force-pushed
the
llvm-c-test-help
branch
from
8dcc50d
to
04325e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former name was introduced during the split between debug info intrinsic and
DbgRecord. Before the split, it was named--test-dibuilder.However, the full migration to
DbgRecordhappened already and we have just one test suite related to building debug info using LLVM-C API. Therefore, it makes sense to rename it back to--test-dibuilder.