[bazel] Move lldb-dap cc_binary to lldb/BUILD.bazel #105733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On linux lldb-dap uses the location of the lldb-dap binary to search for lldb-server. Previously these were produced in different directories corresponding to the BUILD file paths. It's not ideal that the BUILD file location matters for the binary at runtime but it doesn't hurt to have this tool here too like the others.
walter-erquinigo
approved these changes
Aug 23, 2024
cjdb
pushed a commit
to cjdb/llvm-project
that referenced
this pull request
Aug 23, 2024
On linux lldb-dap uses the location of the lldb-dap binary to search for lldb-server. Previously these were produced in different directories corresponding to the BUILD file paths. It's not ideal that the BUILD file location matters for the binary at runtime but it doesn't hurt to have this tool here too like the others.
dmpolukhin
pushed a commit
to dmpolukhin/llvm-project
that referenced
this pull request
Sep 2, 2024
On linux lldb-dap uses the location of the lldb-dap binary to search for lldb-server. Previously these were produced in different directories corresponding to the BUILD file paths. It's not ideal that the BUILD file location matters for the binary at runtime but it doesn't hurt to have this tool here too like the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On linux lldb-dap uses the location of the lldb-dap binary to search for
lldb-server. Previously these were produced in different directories
corresponding to the BUILD file paths. It's not ideal that the BUILD
file location matters for the binary at runtime but it doesn't hurt to
have this tool here too like the others.