[SCCP] fix non-determinism #105758
Merged
[SCCP] fix non-determinism #105758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
|
@llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-llvm-transforms Author: Florian Mayer (fmayer) Changesthe visit order depended on hashing because we iterated over a Full diff: https://github.com/llvm/llvm-project/pull/105758.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Utils/SCCPSolver.cpp b/llvm/lib/Transforms/Utils/SCCPSolver.cpp
index 40f0f04c323ddc..670d88ac7cf8fa 100644
--- a/llvm/lib/Transforms/Utils/SCCPSolver.cpp
+++ b/llvm/lib/Transforms/Utils/SCCPSolver.cpp
@@ -13,6 +13,7 @@
//===----------------------------------------------------------------------===//
#include "llvm/Transforms/Utils/SCCPSolver.h"
+#include "llvm/ADT/SetVector.h"
#include "llvm/Analysis/ConstantFolding.h"
#include "llvm/Analysis/InstructionSimplify.h"
#include "llvm/Analysis/ValueLattice.h"
@@ -418,7 +419,7 @@ class SCCPInstVisitor : public InstVisitor<SCCPInstVisitor> {
DenseMap<Function *, std::unique_ptr<PredicateInfo>> FnPredicateInfo;
- DenseMap<Value *, SmallPtrSet<User *, 2>> AdditionalUsers;
+ DenseMap<Value *, SmallSetVector<User *, 2>> AdditionalUsers;
LLVMContext &Ctx;
|
RKSimon
reviewed
Aug 23, 2024
|
presubmit failure seems like an infra issue, is happening on all recent PRs. |
cjdb
pushed a commit
to cjdb/llvm-project
that referenced
this pull request
Aug 23, 2024
the visit order depended on hashing because we iterated over a SmallPtrSet
5chmidti
pushed a commit
that referenced
this pull request
Aug 24, 2024
the visit order depended on hashing because we iterated over a SmallPtrSet
dmpolukhin
pushed a commit
to dmpolukhin/llvm-project
that referenced
this pull request
Sep 2, 2024
the visit order depended on hashing because we iterated over a SmallPtrSet
fmayer
added a commit
to fmayer/llvm-project
that referenced
this pull request
Sep 13, 2024
the visit order depended on hashing because we iterated over a SmallPtrSet Ordering of codegen of one test changed, but is equivalent Reviewers: nikic Reviewed By: nikic Pull Request: llvm#105758
jroelofs
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 29, 2024
the visit order depended on hashing because we iterated over a SmallPtrSet (cherry picked from commit aec3ec0)
jroelofs
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 30, 2024
the visit order depended on hashing because we iterated over a SmallPtrSet (cherry picked from commit aec3ec0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the visit order depended on hashing because we iterated over a
SmallPtrSet