Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mips] Remove a trivial variable (NFC) #105940

Merged

Conversation

kazutakahirata
Copy link
Contributor

We assign I->getNumOperands() to J and immediately print that out as a
debug message. We don't need to keep J across iterations.

We assign I->getNumOperands() to J and immediately print that out as a
debug message.  We don't need to keep J across iterations.
@kazutakahirata kazutakahirata merged commit a6f87ab into llvm:main Aug 24, 2024
9 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_MIPS_trivial_var branch August 24, 2024 23:20
kaitingwang pushed a commit to kaitingwang/llvm-project that referenced this pull request Aug 24, 2024
We assign I->getNumOperands() to J and immediately print that out as a
debug message.  We don't need to keep J across iterations.
@llvm-ci
Copy link
Collaborator

llvm-ci commented Aug 24, 2024

LLVM Buildbot has detected a new failure on builder clang-arm64-windows-msvc running on linaro-armv8-windows-msvc-04 while building llvm at step 5 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/1536

Here is the relevant piece of the build log for the reference:

Step 5 (ninja check 1) failure: stage 1 checked (failure)
******************** TEST 'Clang :: Modules/hashing-decls-in-exprs-from-gmf.cppm' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
rm -rf C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\tools\clang\test\Modules\Output\hashing-decls-in-exprs-from-gmf.cppm.tmp
# executed command: rm -rf 'C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\tools\clang\test\Modules\Output\hashing-decls-in-exprs-from-gmf.cppm.tmp'
# RUN: at line 2
mkdir -p C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\tools\clang\test\Modules\Output\hashing-decls-in-exprs-from-gmf.cppm.tmp
# executed command: mkdir -p 'C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\tools\clang\test\Modules\Output\hashing-decls-in-exprs-from-gmf.cppm.tmp'
# RUN: at line 3
split-file C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\clang\test\Modules\hashing-decls-in-exprs-from-gmf.cppm C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\tools\clang\test\Modules\Output\hashing-decls-in-exprs-from-gmf.cppm.tmp
# executed command: split-file 'C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\clang\test\Modules\hashing-decls-in-exprs-from-gmf.cppm' 'C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\stage1\tools\clang\test\Modules\Output\hashing-decls-in-exprs-from-gmf.cppm.tmp'
# .---command stderr------------
# | split-file: error: C:\Users\tcwg\llvm-worker\clang-arm64-windows-msvc\llvm\clang\test\Modules\hashing-decls-in-exprs-from-gmf.cppm: permission denied
# `-----------------------------
# error: command failed with exit status: 1

--

********************


dmpolukhin pushed a commit to dmpolukhin/llvm-project that referenced this pull request Sep 2, 2024
We assign I->getNumOperands() to J and immediately print that out as a
debug message.  We don't need to keep J across iterations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants