Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X86][AMX] Avoid to construct invalid shape for checking, NFCI #105973

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

phoebewang
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Aug 25, 2024

@llvm/pr-subscribers-llvm-regalloc

Author: Phoebe Wang (phoebewang)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/105973.diff

1 Files Affected:

  • (modified) llvm/include/llvm/CodeGen/VirtRegMap.h (+1-1)
diff --git a/llvm/include/llvm/CodeGen/VirtRegMap.h b/llvm/include/llvm/CodeGen/VirtRegMap.h
index 42e8d294a637ad..864eb23e133ebd 100644
--- a/llvm/include/llvm/CodeGen/VirtRegMap.h
+++ b/llvm/include/llvm/CodeGen/VirtRegMap.h
@@ -114,7 +114,7 @@ class TargetInstrInfo;
     bool isShapeMapEmpty() const { return Virt2ShapeMap.empty(); }
 
     bool hasShape(Register virtReg) const {
-      return getShape(virtReg).isValid();
+      return Virt2ShapeMap.contains(virtReg);
     }
 
     ShapeT getShape(Register virtReg) const {

@phoebewang phoebewang merged commit 5c94dd7 into llvm:main Aug 25, 2024
10 checks passed
@phoebewang phoebewang deleted the AMX2 branch August 25, 2024 06:01
dmpolukhin pushed a commit to dmpolukhin/llvm-project that referenced this pull request Sep 2, 2024
qiaojbao pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Sep 30, 2024
…5f5c22c46

Local branch amd-gfx ae15f5c Merged main:0916ae49b89db6eb9eee9f6fee4f1a65fd9cdb74 into amd-gfx:b0eb828c0946
Remote branch main 5c94dd7 [X86][AMX] Avoid to construct invalid shape for checking, NFCI (llvm#105973)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants