Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++][math] Provide overloads for cv-unqualified floating point types for std::signbit #106566

Merged
merged 5 commits into from
Sep 12, 2024

Commits on Sep 5, 2024

  1. Configuration menu
    Copy the full SHA
    7804824 View commit details
    Browse the repository at this point in the history
  2. Add floating point overloads for std::signbit

    By using `_LIBCPP_PREFERRED_OVERLOAD` we make
    sure that a given overload is a better match
    than an otherwise equally good function
    declaration.
    
    Why is there an equally good function
    declaration in the first place? Underlying the
    Windows SDK is the UCRT, the universal C runtime,
    which clang-cl makes use of. The UCRT should
    provide only C library headers, but does on top
    comes with overloads for all cv-unqualified floating
    point types (float, double, long double) for
    `std::signbit()` in https://github.com/microsoft/win32metadata/blob/e012b29924c53aa941fc010850b68331b0c3ea80/generation/WinSDK/RecompiledIdlHeaders/ucrt/corecrt_math.h#L309-L322.
    In a certain way, this can be seen as a deviation
    from the C standard. We need to work around it.
    robincaloudis committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    528be9e View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Configuration menu
    Copy the full SHA
    9c24e8d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    d7e4b9b View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Remove unused header

    robincaloudis committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c5f0338 View commit details
    Browse the repository at this point in the history