-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeGen] Fix InstructionCount remarks for MI bundles #107621
[CodeGen] Fix InstructionCount remarks for MI bundles #107621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably by design. Code is supposed to logically treat a bundle as one instruction
Some targets use bundles to mark instruction packet boundaries, no? IMO, that shouldn't be counted as one instruction. |
Yes, that was the original use (assuming some details about how packets are represented). I don't know what "InstructionCount" here is supposed to really mean though |
I think regardless of bundles, they're still real MachineInstrs that get emitted, I don't see why they wouldn't get counted as regular instructions. I can see this count being a problem for pseudos that get expanded directly into MCInsts, but not for bundles. |
6ba6dff
to
3483c7c
Compare
3483c7c
to
7be8d66
Compare
218a464
to
3caf9d4
Compare
70e5a57
to
53d83c0
Compare
For MI bundles, the instruction count remark doesn't count the instructions inside the bundle.
53d83c0
to
fdffa1a
Compare
For MI bundles, the instruction count remark doesn't count the instructions inside the bundle.
For MI bundles, the instruction count remark doesn't count the instructions inside the bundle.
For MI bundles, the instruction count remark doesn't count the instructions inside the bundle.