Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Triple] Make mipsel-*-windows-* use COFF files by default #107809

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

hpoussin
Copy link
Contributor

@hpoussin hpoussin commented Sep 9, 2024

Windows NT/MIPS and Windows CE/MIPS always used COFF format.

This is an extract of PR #107744.

Copy link

github-actions bot commented Sep 9, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this looks reasonable.

Windows NT/MIPS and Windows CE/MIPS always used COFF format.
@hpoussin
Copy link
Contributor Author

Ping.
The commit has been approved by reviewer @mstorsjo. What is the next step?

@mstorsjo
Copy link
Member

Ping. The commit has been approved by reviewer @mstorsjo. What is the next step?

The next steps would be for me or someone else to press the merge button.

I think this change in itself is fine, but I was kind of hoping to see more followup from others on the discussion at #107744 (comment).

@hpoussin
Copy link
Contributor Author

Any news on this PR ?

@wzssyqa wzssyqa merged commit c6ba7b3 into llvm:main Oct 15, 2024
7 checks passed
Copy link

@hpoussin Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

DanielCChen pushed a commit to DanielCChen/llvm-project that referenced this pull request Oct 16, 2024
Windows NT/MIPS and Windows CE/MIPS always used COFF format.

This is an extract of PR llvm#107744.
bricknerb pushed a commit to bricknerb/llvm-project that referenced this pull request Oct 17, 2024
Windows NT/MIPS and Windows CE/MIPS always used COFF format.

This is an extract of PR llvm#107744.
EricWF pushed a commit to efcs/llvm-project that referenced this pull request Oct 22, 2024
Windows NT/MIPS and Windows CE/MIPS always used COFF format.

This is an extract of PR llvm#107744.
@hpoussin hpoussin deleted the clang-mips-coff-1 branch January 21, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants