[Sanitizer] Call Die() instead of Abort() when failed to reserve shadow memory range

[Enna1]

I grep the code and find that Abort() is only called in Die() when the flag abort_on_error is set.
Thus, if reserving shadow memory range fails, Die() rather than Abort() should be called. In this case, the flag abort_on_error will be respected and the die callbacks will be called.

[llvmbot]

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Enna1 (Enna1)

Changes

I grep the code and find that Abort() is only called in Die() when the flag abort_on_error is set.
Thus, if reserving shadow memory range fails, Die() rather than Abort() should be called. In this case, the flag abort_on_error will be respected and the die callbacks will be called.

---

Full diff: https://github.com/llvm/llvm-project/pull/107833.diff

1 Files Affected:

• (modified) compiler-rt/lib/sanitizer_common/sanitizer_common_libcdep.cpp (+1-1)

diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_common_libcdep.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_common_libcdep.cpp
index 3966d82d51ee96..684720963a8dcb 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_common_libcdep.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_common_libcdep.cpp
@@ -171,7 +171,7 @@ void ReserveShadowMemoryRange(uptr beg, uptr end, const char *name,
         "ReserveShadowMemoryRange failed while trying to map 0x%zx bytes. "
         "Perhaps you're using ulimit -v or ulimit -d\n",
         size);
-    Abort();
+    Die();
   }
   if (madvise_shadow && common_flags()->use_madv_dontdump)
     DontDumpShadowMemory(beg, size);