Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir][docs] Fix broken links in PDLL.md #107965

Merged
merged 2 commits into from
Oct 12, 2024
Merged

[mlir][docs] Fix broken links in PDLL.md #107965

merged 2 commits into from
Oct 12, 2024

Conversation

PragmaTwice
Copy link
Contributor

https://mlir.llvm.org/docs/OpDefinitions/ has already been moved (as a broken link now).

Here it's fixed to the form of relative reference DefiningDialects/Operations.md along with other links.

@llvmbot llvmbot added the mlir label Sep 10, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 10, 2024

@llvm/pr-subscribers-mlir

Author: Twice (PragmaTwice)

Changes

https://mlir.llvm.org/docs/OpDefinitions/ has already been moved (as a broken link now).

Here it's fixed to the form of relative reference DefiningDialects/Operations.md along with other links.


Full diff: https://github.com/llvm/llvm-project/pull/107965.diff

1 Files Affected:

  • (modified) mlir/docs/PDLL.md (+5-5)
diff --git a/mlir/docs/PDLL.md b/mlir/docs/PDLL.md
index f5651156a860ca..ee1b615a2dcdee 100644
--- a/mlir/docs/PDLL.md
+++ b/mlir/docs/PDLL.md
@@ -5,8 +5,8 @@ writing pattern rewrites targeting MLIR.
 
 Note: This document assumes a familiarity with MLIR concepts; more specifically
 the concepts detailed within the
-[MLIR Pattern Rewriting](https://mlir.llvm.org/docs/PatternRewriter/) and
-[Operation Definition Specification (ODS)](https://mlir.llvm.org/docs/OpDefinitions/)
+[MLIR Pattern Rewriting](PatternRewriter.md) and
+[Operation Definition Specification (ODS)](DefiningDialects/Operations.md)
 documentation.
 
 [TOC]
@@ -34,11 +34,11 @@ that no longer exist.
 ### Why build a new language instead of improving TableGen DRR?
 
 Note: This section assumes familiarity with
-[TDRR](https://mlir.llvm.org/docs/DeclarativeRewrites/), please refer the
+[TDRR](DeclarativeRewrites.md), please refer the
 relevant documentation before continuing.
 
 Tablegen DRR (TDRR), i.e.
-[Table-driven Declarative Rewrite Rules](https://mlir.llvm.org/docs/DeclarativeRewrites/),
+[Table-driven Declarative Rewrite Rules](DeclarativeRewrites.md),
 is a declarative DSL for defining MLIR pattern rewrites within the
 [TableGen](https://llvm.org/docs/TableGen/index.html) language. This
 infrastructure is currently the main way in which patterns may be defined
@@ -257,7 +257,7 @@ the current file.
 #### `.td` includes
 
 When including a `.td` file, PDLL will automatically import any pertinent
-[ODS](https://mlir.llvm.org/docs/OpDefinitions/) information within that file.
+[ODS](DefiningDialects/Operations.md) information within that file.
 This includes any defined operations, constraints, interfaces, and more, making
 them implicitly accessible within PDLL. This is important, as ODS information
 allows for certain PDLL constructs, such as the

@MacDue MacDue merged commit 6976dee into llvm:main Oct 12, 2024
10 checks passed
DanielCChen pushed a commit to DanielCChen/llvm-project that referenced this pull request Oct 16, 2024
`https://mlir.llvm.org/docs/OpDefinitions/` has already been moved (as a
broken link now).

Here it's fixed to the form of relative reference
`DefiningDialects/Operations.md` along with other links.
bricknerb pushed a commit to bricknerb/llvm-project that referenced this pull request Oct 17, 2024
`https://mlir.llvm.org/docs/OpDefinitions/` has already been moved (as a
broken link now).

Here it's fixed to the form of relative reference
`DefiningDialects/Operations.md` along with other links.
EricWF pushed a commit to efcs/llvm-project that referenced this pull request Oct 22, 2024
`https://mlir.llvm.org/docs/OpDefinitions/` has already been moved (as a
broken link now).

Here it's fixed to the form of relative reference
`DefiningDialects/Operations.md` along with other links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants