-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc++] Granularize <cstddef> includes #108696
Draft
philnik777
wants to merge
1
commit into
llvm:main
Choose a base branch
from
philnik777:granularize_cstddef_includes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+208
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can test this locally with the following command:git-clang-format --diff 2fb133f32af42b29e1e1bbbbc24fb75eea3f34a2 6bfe8136c0744068ea2c134b5c4cf8f3323e7ef5 --extensions h,,cpp -- libcxx/include/__algorithm/copy_move_common.h libcxx/include/__algorithm/inplace_merge.h libcxx/include/__algorithm/mismatch.h libcxx/include/__algorithm/shuffle.h libcxx/include/__algorithm/simd_utils.h libcxx/include/__algorithm/stable_partition.h libcxx/include/__algorithm/stable_sort.h libcxx/include/__atomic/aliases.h libcxx/include/__atomic/atomic.h libcxx/include/__atomic/atomic_ref.h libcxx/include/__atomic/cxx_atomic_impl.h libcxx/include/__charconv/to_chars_integral.h libcxx/include/__compare/common_comparison_category.h libcxx/include/__concepts/swappable.h libcxx/include/__coroutine/coroutine_handle.h libcxx/include/__exception/exception_ptr.h libcxx/include/__exception/nested_exception.h libcxx/include/__exception/operations.h libcxx/include/__filesystem/directory_iterator.h libcxx/include/__filesystem/path.h libcxx/include/__filesystem/path_iterator.h libcxx/include/__filesystem/recursive_directory_iterator.h libcxx/include/__format/buffer.h libcxx/include/__format/escaped_output_table.h libcxx/include/__format/extended_grapheme_cluster_table.h libcxx/include/__format/format_args.h libcxx/include/__format/format_context.h libcxx/include/__format/format_string.h libcxx/include/__format/formatter_floating_point.h libcxx/include/__format/formatter_output.h libcxx/include/__format/formatter_pointer.h libcxx/include/__format/indic_conjunct_break_table.h libcxx/include/__format/width_estimation_table.h libcxx/include/__functional/bind.h libcxx/include/__functional/hash.h libcxx/include/__hash_table libcxx/include/__iterator/access.h libcxx/include/__iterator/aliasing_iterator.h libcxx/include/__iterator/back_insert_iterator.h libcxx/include/__iterator/data.h libcxx/include/__iterator/empty.h libcxx/include/__iterator/front_insert_iterator.h libcxx/include/__iterator/incrementable_traits.h libcxx/include/__iterator/insert_iterator.h libcxx/include/__iterator/istream_iterator.h libcxx/include/__iterator/iterator.h libcxx/include/__iterator/iterator_traits.h libcxx/include/__iterator/ostream_iterator.h libcxx/include/__iterator/ostreambuf_iterator.h libcxx/include/__iterator/reverse_access.h libcxx/include/__iterator/segmented_iterator.h libcxx/include/__iterator/size.h libcxx/include/__iterator/wrap_iter.h libcxx/include/__mdspan/default_accessor.h libcxx/include/__mdspan/extents.h libcxx/include/__mdspan/layout_left.h libcxx/include/__mdspan/layout_right.h libcxx/include/__mdspan/layout_stride.h libcxx/include/__mdspan/mdspan.h libcxx/include/__memory/align.h libcxx/include/__memory/aligned_alloc.h libcxx/include/__memory/allocate_at_least.h libcxx/include/__memory/allocation_guard.h libcxx/include/__memory/allocator.h libcxx/include/__memory/allocator_traits.h libcxx/include/__memory/assume_aligned.h libcxx/include/__memory/builtin_new_allocator.h libcxx/include/__memory/compressed_pair.h libcxx/include/__memory/destruct_n.h libcxx/include/__memory/pointer_traits.h libcxx/include/__memory/raw_storage_iterator.h libcxx/include/__memory/shared_ptr.h libcxx/include/__memory/temporary_buffer.h libcxx/include/__memory/unique_ptr.h libcxx/include/__memory/uses_allocator.h libcxx/include/__memory_resource/memory_resource.h libcxx/include/__memory_resource/monotonic_buffer_resource.h libcxx/include/__memory_resource/polymorphic_allocator.h libcxx/include/__memory_resource/pool_options.h libcxx/include/__memory_resource/synchronized_pool_resource.h libcxx/include/__memory_resource/unsynchronized_pool_resource.h libcxx/include/__numeric/midpoint.h libcxx/include/__ostream/basic_ostream.h libcxx/include/__pstl/backends/libdispatch.h libcxx/include/__pstl/backends/std_thread.h libcxx/include/__pstl/cpu_algos/cpu_traits.h libcxx/include/__pstl/cpu_algos/find_if.h libcxx/include/__pstl/cpu_algos/transform_reduce.h libcxx/include/__random/discard_block_engine.h libcxx/include/__random/discrete_distribution.h libcxx/include/__random/independent_bits_engine.h libcxx/include/__random/log2.h libcxx/include/__random/mersenne_twister_engine.h libcxx/include/__random/piecewise_constant_distribution.h libcxx/include/__random/piecewise_linear_distribution.h libcxx/include/__random/shuffle_order_engine.h libcxx/include/__random/subtract_with_carry_engine.h libcxx/include/__random/uniform_int_distribution.h libcxx/include/__ranges/access.h libcxx/include/__ranges/counted.h libcxx/include/__ranges/drop_view.h libcxx/include/__ranges/elements_view.h libcxx/include/__ranges/empty_view.h libcxx/include/__ranges/istream_view.h libcxx/include/__ranges/repeat_view.h libcxx/include/__ranges/single_view.h libcxx/include/__ranges/size.h libcxx/include/__ranges/subrange.h libcxx/include/__ranges/take_view.h libcxx/include/__ranges/to.h libcxx/include/__split_buffer libcxx/include/__stop_token/intrusive_shared_ptr.h libcxx/include/__string/char_traits.h libcxx/include/__string/constexpr_c_functions.h libcxx/include/__system_error/error_code.h libcxx/include/__system_error/error_condition.h libcxx/include/__utility/in_place.h libcxx/include/__utility/integer_sequence.h libcxx/include/__utility/pair.h libcxx/include/__utility/priority_tag.h libcxx/include/__utility/small_buffer.h libcxx/include/__utility/swap.h libcxx/include/__variant/monostate.h libcxx/include/array libcxx/include/atomic libcxx/include/barrier libcxx/include/bitset libcxx/include/charconv libcxx/include/compare libcxx/include/concepts libcxx/include/coroutine libcxx/include/exception libcxx/include/experimental/__simd/aligned_tag.h libcxx/include/experimental/__simd/declaration.h libcxx/include/experimental/__simd/reference.h libcxx/include/experimental/__simd/scalar.h libcxx/include/experimental/__simd/simd.h libcxx/include/experimental/__simd/simd_mask.h libcxx/include/experimental/__simd/traits.h libcxx/include/experimental/__simd/utility.h libcxx/include/experimental/__simd/vec_ext.h libcxx/include/experimental/iterator libcxx/include/experimental/memory libcxx/include/experimental/propagate_const libcxx/include/experimental/simd libcxx/include/experimental/type_traits libcxx/include/experimental/utility libcxx/include/initializer_list libcxx/include/iterator libcxx/include/latch libcxx/include/mutex libcxx/include/new libcxx/include/numbers libcxx/include/semaphore libcxx/include/span libcxx/include/stdexcept libcxx/include/stop_token libcxx/include/string_view libcxx/include/tuple libcxx/include/typeindex libcxx/include/typeinfo libcxx/include/utility libcxx/include/valarray libcxx/include/variant libcxx/src/memory_resource.cpp libcxx/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.cxx1z.pass.cpp libcxx/test/libcxx/containers/sequences/deque/asan_turning_off.pass.cpp libcxx/test/libcxx/utilities/template.bitset/includes.pass.cpp libcxx/test/std/containers/views/mdspan/extents/CtorTestCombinations.h libcxx/test/std/containers/views/mdspan/extents/obs_static.pass.cpp libcxx/test/std/containers/views/mdspan/layout_left/ctor.default.pass.cpp libcxx/test/std/containers/views/mdspan/layout_left/ctor.extents.pass.cpp libcxx/test/std/containers/views/mdspan/layout_left/required_span_size.pass.cpp libcxx/test/std/containers/views/mdspan/layout_right/ctor.default.pass.cpp libcxx/test/std/containers/views/mdspan/layout_right/ctor.extents.pass.cpp libcxx/test/std/containers/views/mdspan/layout_right/required_span_size.pass.cpp libcxx/test/std/containers/views/mdspan/layout_stride/ctor.default.pass.cpp libcxx/test/std/containers/views/mdspan/layout_stride/required_span_size.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/iterator_sentinel.verify.cpp libcxx/test/std/containers/views/views.span/span.objectrep/as_bytes.pass.cpp libcxx/test/std/containers/views/views.span/span.objectrep/as_writable_bytes.pass.cpp libcxx/test/std/diagnostics/syserr/is_error_code_enum.pass.cpp libcxx/test/std/iterators/iterator.requirements/iterator.assoc.types/incrementable.traits/incrementable_traits.compile.pass.cpp libcxx/test/std/numerics/bit/byteswap.pass.cpp libcxx/test/std/ranges/range.factories/range.repeat.view/iterator/minus.pass.cpp libcxx/test/std/utilities/memory/temporary.buffer/temporary_buffer.pass.cpp libcxxabi/src/private_typeinfo.cpp View the diff from clang-format here.diff --git a/libcxx/test/std/containers/views/mdspan/layout_right/required_span_size.pass.cpp b/libcxx/test/std/containers/views/mdspan/layout_right/required_span_size.pass.cpp
index 0e354b2da5..2ffd1f41f9 100644
--- a/libcxx/test/std/containers/views/mdspan/layout_right/required_span_size.pass.cpp
+++ b/libcxx/test/std/containers/views/mdspan/layout_right/required_span_size.pass.cpp
@@ -14,7 +14,6 @@
//
// Returns: extents().fwd-prod-of-extents(extents_type::rank()).
-
#include <cassert>
#include <cstddef>
#include <cstdint>
diff --git a/libcxx/test/std/containers/views/views.span/span.objectrep/as_bytes.pass.cpp b/libcxx/test/std/containers/views/views.span/span.objectrep/as_bytes.pass.cpp
index a6c2a5a6ba..44b658fb83 100644
--- a/libcxx/test/std/containers/views/views.span/span.objectrep/as_bytes.pass.cpp
+++ b/libcxx/test/std/containers/views/views.span/span.objectrep/as_bytes.pass.cpp
@@ -16,7 +16,6 @@
// : sizeof(ElementType) * Extent>
// as_bytes(span<ElementType, Extent> s) noexcept;
-
#include <cassert>
#include <cstddef>
#include <span>
diff --git a/libcxx/test/std/containers/views/views.span/span.objectrep/as_writable_bytes.pass.cpp b/libcxx/test/std/containers/views/views.span/span.objectrep/as_writable_bytes.pass.cpp
index b5bc58db57..d38d69d9fe 100644
--- a/libcxx/test/std/containers/views/views.span/span.objectrep/as_writable_bytes.pass.cpp
+++ b/libcxx/test/std/containers/views/views.span/span.objectrep/as_writable_bytes.pass.cpp
@@ -16,7 +16,6 @@
// : sizeof(ElementType) * Extent>
// as_writable_bytes(span<ElementType, Extent> s) noexcept;
-
#include <cassert>
#include <cstddef>
#include <span>
|
philnik777
force-pushed
the
granularize_cstddef_includes
branch
from
September 15, 2024 11:05
2bfee2d
to
6bfe813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.