Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcxx] No _LIBCPP_ELAST needed for LLVM libc #108739

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

petrhosek
Copy link
Member

LLVM libc can handle out-of-range errno values.

LLVM libc can handle out-of-range errno values.
@petrhosek petrhosek added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 15, 2024
@petrhosek petrhosek requested a review from a team as a code owner September 15, 2024 07:37
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 15, 2024

@llvm/pr-subscribers-libcxx

Author: Petr Hosek (petrhosek)

Changes

LLVM libc can handle out-of-range errno values.


Full diff: https://github.com/llvm/llvm-project/pull/108739.diff

1 Files Affected:

  • (modified) libcxx/src/include/config_elast.h (+2)
diff --git a/libcxx/src/include/config_elast.h b/libcxx/src/include/config_elast.h
index 899e124ad261b2..158b93e20040dd 100644
--- a/libcxx/src/include/config_elast.h
+++ b/libcxx/src/include/config_elast.h
@@ -21,6 +21,8 @@
 // where strerror/strerror_r can't handle out-of-range errno values.
 #if defined(ELAST)
 #  define _LIBCPP_ELAST ELAST
+#elif defined(__LLVM_LIBC__)
+// No _LIBCPP_ELAST needed for LLVM libc
 #elif defined(_NEWLIB_VERSION)
 #  define _LIBCPP_ELAST __ELASTERROR
 #elif defined(__NuttX__)

@petrhosek
Copy link
Member Author

Ping?

Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if all libc++ PRs require someone from the team to sign-off, but this is pretty trivial and passed CI so I don't see any reason it shouldn't be approved.

Copy link
Contributor

@philnik777 philnik777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if all libc++ PRs require someone from the team to sign-off

Generally yes. In this specific case maybe not, since it only touches a configuration that's not ABI stable, but that's not necessarily trivial to determine.

@petrhosek petrhosek merged commit 4f0187d into llvm:main Sep 20, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants