[libc++][CI] Upgrade compiler HEAD version to Clang-20 #108761
Draft
+20
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the Python code formatter. |
robincaloudis
force-pushed
the
rc-ci-clang-20
branch
2 times, most recently
from
2fa7cdb
to
7c9c19a
Compare
Zingam
reviewed
Sep 15, 2024
Zingam
reviewed
Sep 15, 2024
libcxx/test/std/utilities/variant/variant.visit.member/robust_against_adl.pass.cpp
Outdated
Show resolved
Hide resolved
Zingam
reviewed
Sep 15, 2024
libcxx/test/std/numerics/numeric.ops/numeric.ops.sat/add_sat.pass.cpp
Outdated
Show resolved
Hide resolved
robincaloudis
changed the title
robincaloudis
force-pushed
the
rc-ci-clang-20
branch
from
72a3714
to
4a64f35
Compare
philnik777
pushed a commit
that referenced
this pull request
Sep 15, 2024
Before changing the compiler version in #108761, we first of all need to upgrade the HEAD version to `Clang-20` in the Docker files and push new builder images to the CI.
robincaloudis
changed the title
robincaloudis
force-pushed
the
rc-ci-clang-20
branch
2 times, most recently
from
3e9a7ab
to
ed34e6d
Compare
robincaloudis
force-pushed
the
rc-ci-clang-20
branch
from
ed34e6d
to
1ba5736
Compare
Zingam
reviewed
Sep 16, 2024
| LLVM_OLDEST_VERSION: "17" | ||
| LLVM_HEAD_VERSION: "20" # Used compiler, update POST-BRANCH. | ||
| LLVM_PREVIOUS_VERSION: "19" | ||
| LLVM_OLDEST_VERSION: "18" | ||
| GCC_STABLE_VERSION: "13" |
There was a problem hiding this comment.
Suggested change
| GCC_STABLE_VERSION: "13" | |
| GCC_STABLE_VERSION: "14" |
Just an off-topic question: Shouldn't this value be 14?
There was a problem hiding this comment.
Thanks for pointing out! This env variable might be unused. It seems to me that the actual version for gcc is configured here. I will double check my claim.
robincaloudis
force-pushed
the
rc-ci-clang-20
branch
from
1ba5736
to
5746ee8
Compare
Zingam
reviewed
Sep 18, 2024
| # if _LIBCPP_CLANG_VER < 1700 | ||
| # warning "Libc++ only supports Clang 17 and later" | ||
| # if _LIBCPP_CLANG_VER < 1800 | ||
| # warning "Libc++ only supports Clang 18 and later" |
There was a problem hiding this comment.
The buildkite builds fail because AIX, arm, FreeBSD use Clang 17 still:
https://buildkite.com/llvm-project/libcxx-ci/builds/37764#0192014a-8840-47ea-b2bf-31aa8dd679de/2158-2953
There was a problem hiding this comment.
Great hint! Thanks. I did not yet finalized this PR (hence the draft) as we're still working on updating the CI images. This is not yet finished. As long as the images for the CI builders are not updated, this PR will not work. I keep you updated.
robincaloudis
force-pushed
the
rc-ci-clang-20
branch
from
5746ee8
to
594ee7d
Compare
Let's adjust tests and implementation in a seperate PR.
robincaloudis
force-pushed
the
rc-ci-clang-20
branch
from
594ee7d
to
7161e41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The release branch for LLVM 19.x is created (
release/19.x) as anounced here. As a result, the version on main is now20.0.0git. Therefore, we no longer officially supportClang-17, but insteadClang-{18,19,20}.What
Upgrade HEAD version to Clang-20 in CI configs. Adjustments for libc++ tests and implementations will be done in follow-up patches.