Make __libcpp_verbose_abort() noexcept like std::terminate() #109151
Conversation
match std::terminate(). Clang's function effect analysis can use this to ignore such functions as being beyond its scope.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Doug Wyatt (dougsonos) ChangesMake __libcpp_verbose_abort() noexcept (it is already noreturn), to match std::terminate(). Clang's function effect analysis can use this to ignore such functions as being beyond its scope. (See #99656) Full diff: https://github.com/llvm/llvm-project/pull/109151.diff 1 Files Affected:
diff --git a/libcxx/include/__verbose_abort b/libcxx/include/__verbose_abort
index 244278aec652d2..45a0add493c17d 100644
--- a/libcxx/include/__verbose_abort
+++ b/libcxx/include/__verbose_abort
@@ -21,7 +21,8 @@ _LIBCPP_BEGIN_NAMESPACE_STD
// This function should never be called directly from the code -- it should only be called through
// the _LIBCPP_VERBOSE_ABORT macro.
[[__noreturn__]] _LIBCPP_AVAILABILITY_VERBOSE_ABORT _LIBCPP_OVERRIDABLE_FUNC_VIS
-_LIBCPP_ATTRIBUTE_FORMAT(__printf__, 1, 2) void __libcpp_verbose_abort(const char* __format, ...);
+_LIBCPP_ATTRIBUTE_FORMAT(__printf__, 1, 2) void __libcpp_verbose_abort(const char* __format, ...)
+_NOEXCEPT;
// _LIBCPP_VERBOSE_ABORT(format, args...)
//
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Oops, I forgot to make the implementation |
There was a problem hiding this comment.
This makes sense to me, however this is technically a breaking change because in the past we have advertised __libcpp_verbose_abort as being overridable (that's why it was a weak def).
We'd also want to add a release note for this change in libcxx/docs/ReleaseNotes/20.rst, probably under Deprecations and Removals.
Pinging @llvm/libcxx-vendors for awareness.
|
Any pointers on what's going on with the test builds? I click Details and just see "job failed". |
Make __libcpp_verbose_abort() noexcept (it is already noreturn), to match std::terminate(). Clang's function effect analysis can use this to ignore such functions as being beyond its scope. (See #99656)