Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBC] Fix build failure caused by #110032 #110539

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jurahul
Copy link
Contributor

@jurahul jurahul commented Sep 30, 2024

Fix LibC TableGen build failure caused by #110032

Fix LibC TableGen build failure caused by llvm#110032
@jurahul jurahul requested a review from arsenm September 30, 2024 17:34
@jurahul jurahul marked this pull request as ready for review September 30, 2024 17:34
@llvmbot llvmbot added the libc label Sep 30, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 30, 2024

@llvm/pr-subscribers-libc

Author: Rahul Joshi (jurahul)

Changes

Fix LibC TableGen build failure caused by #110032


Full diff: https://github.com/llvm/llvm-project/pull/110539.diff

1 Files Affected:

  • (modified) libc/utils/LibcTableGenUtil/APIIndexer.cpp (+2-2)
diff --git a/libc/utils/LibcTableGenUtil/APIIndexer.cpp b/libc/utils/LibcTableGenUtil/APIIndexer.cpp
index 65814b96f7f43e..0a77584071f996 100644
--- a/libc/utils/LibcTableGenUtil/APIIndexer.cpp
+++ b/libc/utils/LibcTableGenUtil/APIIndexer.cpp
@@ -25,8 +25,8 @@ static const char StandardSpecClassName[] = "StandardSpec";
 static const char PublicAPIClassName[] = "PublicAPI";
 
 static bool isa(const llvm::Record *Def, const llvm::Record *TypeClass) {
-  llvm::RecordRecTy *RecordType = Def->getType();
-  llvm::ArrayRef<llvm::Record *> Classes = RecordType->getClasses();
+  const llvm::RecordRecTy *RecordType = Def->getType();
+  llvm::ArrayRef<const llvm::Record *> Classes = RecordType->getClasses();
   // We want exact types. That is, we don't want the classes listed in
   // spec.td to be subclassed. Hence, we do not want the record |Def|
   // to be of more than one class type..

@jurahul jurahul merged commit 005f815 into llvm:main Sep 30, 2024
9 of 10 checks passed
@jurahul jurahul deleted the fix_build_failure_libc branch September 30, 2024 17:36
VitaNuo pushed a commit to VitaNuo/llvm-project that referenced this pull request Oct 2, 2024
VitaNuo pushed a commit to VitaNuo/llvm-project that referenced this pull request Oct 2, 2024
xgupta pushed a commit to xgupta/llvm-project that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants