-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mlir] Fix typos in documentation #110869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-mlir-func Author: Timothy Hoffman (tim-hoffman) ChangesFull diff: https://github.com/llvm/llvm-project/pull/110869.diff 3 Files Affected:
diff --git a/mlir/docs/DefiningDialects/Operations.md b/mlir/docs/DefiningDialects/Operations.md
index c252d9caf98eba..d93c0e7146011c 100644
--- a/mlir/docs/DefiningDialects/Operations.md
+++ b/mlir/docs/DefiningDialects/Operations.md
@@ -756,7 +756,7 @@ The available directives are as follows:
* `ref ( input )`
- - Represents a reference to the a variable or directive, that must have
+ - Represents a reference to a variable or directive, that must have
already been resolved, that may be used as a parameter to a `custom`
directive.
- Used to pass previously parsed entities to custom directives.
diff --git a/mlir/docs/DefiningDialects/_index.md b/mlir/docs/DefiningDialects/_index.md
index 83070b616d0ef7..5196092dfbda11 100644
--- a/mlir/docs/DefiningDialects/_index.md
+++ b/mlir/docs/DefiningDialects/_index.md
@@ -133,7 +133,7 @@ void MyOp::setOtherValue(StringAttr newValue);
### Dependent Dialects
-MLIR has a very large ecosystem, and contains dialects that server many different purposes. It
+MLIR has a very large ecosystem, and contains dialects that serve many different purposes. It
is quite common, given the above, that dialects may want to reuse certain components from other
dialects. This may mean generating operations from those dialects during canonicalization, reusing
attributes or types, etc. When a dialect has a dependency on another, i.e. when it constructs and/or
diff --git a/mlir/include/mlir/Dialect/Func/IR/FuncOps.td b/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
index cca0008cbc2633..22efe15aa83a50 100644
--- a/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
+++ b/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
@@ -251,7 +251,7 @@ def FuncOp : Func_Op<"func", [
// A function that returns its argument twice:
func.func @count(%x: i64) -> (i64, i64)
- attributes {fruit: "banana"} {
+ attributes {fruit = "banana"} {
return %x, %x: i64, i64
}
|
@llvm/pr-subscribers-mlir Author: Timothy Hoffman (tim-hoffman) ChangesFull diff: https://github.com/llvm/llvm-project/pull/110869.diff 3 Files Affected:
diff --git a/mlir/docs/DefiningDialects/Operations.md b/mlir/docs/DefiningDialects/Operations.md
index c252d9caf98eba..d93c0e7146011c 100644
--- a/mlir/docs/DefiningDialects/Operations.md
+++ b/mlir/docs/DefiningDialects/Operations.md
@@ -756,7 +756,7 @@ The available directives are as follows:
* `ref ( input )`
- - Represents a reference to the a variable or directive, that must have
+ - Represents a reference to a variable or directive, that must have
already been resolved, that may be used as a parameter to a `custom`
directive.
- Used to pass previously parsed entities to custom directives.
diff --git a/mlir/docs/DefiningDialects/_index.md b/mlir/docs/DefiningDialects/_index.md
index 83070b616d0ef7..5196092dfbda11 100644
--- a/mlir/docs/DefiningDialects/_index.md
+++ b/mlir/docs/DefiningDialects/_index.md
@@ -133,7 +133,7 @@ void MyOp::setOtherValue(StringAttr newValue);
### Dependent Dialects
-MLIR has a very large ecosystem, and contains dialects that server many different purposes. It
+MLIR has a very large ecosystem, and contains dialects that serve many different purposes. It
is quite common, given the above, that dialects may want to reuse certain components from other
dialects. This may mean generating operations from those dialects during canonicalization, reusing
attributes or types, etc. When a dialect has a dependency on another, i.e. when it constructs and/or
diff --git a/mlir/include/mlir/Dialect/Func/IR/FuncOps.td b/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
index cca0008cbc2633..22efe15aa83a50 100644
--- a/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
+++ b/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
@@ -251,7 +251,7 @@ def FuncOp : Func_Op<"func", [
// A function that returns its argument twice:
func.func @count(%x: i64) -> (i64, i64)
- attributes {fruit: "banana"} {
+ attributes {fruit = "banana"} {
return %x, %x: i64, i64
}
|
MacDue
approved these changes
Oct 12, 2024
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
bricknerb
pushed a commit
to bricknerb/llvm-project
that referenced
this pull request
Oct 17, 2024
EricWF
pushed a commit
to efcs/llvm-project
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.