Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: Add vector dialect dependency. #110927

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

bjacob
Copy link
Contributor

@bjacob bjacob commented Oct 2, 2024

Following up on #110904.

Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
@bjacob bjacob force-pushed the bjacob/bazel-VectorDialect-dependency branch from 5ba432d to b65b729 Compare October 2, 2024 20:54
@bjacob bjacob marked this pull request as ready for review October 2, 2024 20:56
@bjacob bjacob requested review from rupprecht and keith as code owners October 2, 2024 20:56
@llvmbot llvmbot added the bazel "Peripheral" support tier build system: utils/bazel label Oct 2, 2024
@bjacob bjacob requested a review from cjdb October 2, 2024 20:57
@bjacob bjacob merged commit d24fdce into llvm:main Oct 2, 2024
9 checks passed
hanhanW added a commit to iree-org/iree that referenced this pull request Oct 2, 2024
Cherry-picks:
1. llvm/llvm-project#110918
2. llvm/llvm-project#110904
3. llvm/llvm-project#110927

The revision disables the pack/unpack decomposition when any of inner
tiles is dynamic. Because it leads to unbounded stack allocation (which
is introduced by tensor.pad op). It's broken by the `Extend the logic to
generalise tensor.pack` commits. See
llvm/llvm-project@66f84c8
and
llvm/llvm-project@1c01bcb.

---------

Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
Co-authored-by: hanhanW <hanhan0912@gmail.com>
Sterling-Augustine pushed a commit to Sterling-Augustine/llvm-project that referenced this pull request Oct 3, 2024
Following up on llvm#110904.

Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
xgupta pushed a commit to xgupta/llvm-project that referenced this pull request Oct 4, 2024
Following up on llvm#110904.

Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants