Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIR] Add missing noteNewVirtualRegister callbacks #111634

Conversation

optimisan
Copy link
Contributor

@optimisan optimisan commented Oct 9, 2024

The delegates' callback isn't invoked on parsing new virtual registers.

There are two places in the serialization where new virtual registers can be discovered: in register infos and in instructions.

Copy link
Contributor Author

optimisan commented Oct 9, 2024

@optimisan optimisan marked this pull request as ready for review October 9, 2024 05:59
Copy link
Collaborator

@cdevadas cdevadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes you made in llvm/lib/CodeGen/MIRParser/MIRParser.cpp are not related to this PR.
Create a separate NFC patch for it.

@optimisan optimisan force-pushed the users/Akshat-Oke/10-09-_mir_add_missing_notenewvirtualregister_callbacks branch from 2b87714 to 8e7f366 Compare October 9, 2024 06:16
@Ayush9054

This comment was marked as off-topic.

@optimisan optimisan force-pushed the users/Akshat-Oke/09-27-_mir_serialize_virtual_register_flags branch from c936e00 to d167efd Compare October 14, 2024 08:21
@optimisan optimisan force-pushed the users/Akshat-Oke/10-09-_mir_add_missing_notenewvirtualregister_callbacks branch from bf5cc39 to 9dd1158 Compare October 14, 2024 08:21
@optimisan optimisan force-pushed the users/Akshat-Oke/09-27-_mir_serialize_virtual_register_flags branch from d167efd to 5e1c572 Compare October 14, 2024 08:30
@optimisan optimisan force-pushed the users/Akshat-Oke/10-09-_mir_add_missing_notenewvirtualregister_callbacks branch from 9dd1158 to 9390926 Compare October 14, 2024 08:31
Base automatically changed from users/Akshat-Oke/09-27-_mir_serialize_virtual_register_flags to main October 14, 2024 08:49
@optimisan optimisan force-pushed the users/Akshat-Oke/10-09-_mir_add_missing_notenewvirtualregister_callbacks branch from 9390926 to 38a9c7b Compare October 14, 2024 08:51
@optimisan
Copy link
Contributor Author

optimisan commented Oct 14, 2024

Merge activity

  • Oct 14, 4:57 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 14, 4:59 AM EDT: A user merged this pull request with Graphite.

@optimisan optimisan merged commit 3dba5d8 into main Oct 14, 2024
5 of 7 checks passed
@optimisan optimisan deleted the users/Akshat-Oke/10-09-_mir_add_missing_notenewvirtualregister_callbacks branch October 14, 2024 08:59
Stylie777 pushed a commit to Stylie777/llvm-project that referenced this pull request Oct 14, 2024
The delegates' callback isn't invoked on parsing new virtual registers.

There are two places in the serialization where new virtual registers can be discovered: in register infos and in instructions.
DanielCChen pushed a commit to DanielCChen/llvm-project that referenced this pull request Oct 16, 2024
The delegates' callback isn't invoked on parsing new virtual registers.

There are two places in the serialization where new virtual registers can be discovered: in register infos and in instructions.
bricknerb pushed a commit to bricknerb/llvm-project that referenced this pull request Oct 17, 2024
The delegates' callback isn't invoked on parsing new virtual registers.

There are two places in the serialization where new virtual registers can be discovered: in register infos and in instructions.
EricWF pushed a commit to efcs/llvm-project that referenced this pull request Oct 22, 2024
The delegates' callback isn't invoked on parsing new virtual registers.

There are two places in the serialization where new virtual registers can be discovered: in register infos and in instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants