-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIR] Add missing noteNewVirtualRegister callbacks #111634
Merged
optimisan
merged 2 commits into
main
from
users/Akshat-Oke/10-09-_mir_add_missing_notenewvirtualregister_callbacks
Oct 14, 2024
Merged
[MIR] Add missing noteNewVirtualRegister callbacks #111634
optimisan
merged 2 commits into
main
from
users/Akshat-Oke/10-09-_mir_add_missing_notenewvirtualregister_callbacks
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @optimisan and the rest of your teammates on |
cdevadas
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes you made in llvm/lib/CodeGen/MIRParser/MIRParser.cpp are not related to this PR.
Create a separate NFC patch for it.
2b87714
to
8e7f366
Compare
arsenm
approved these changes
Oct 9, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
c936e00
to
d167efd
Compare
bf5cc39
to
9dd1158
Compare
d167efd
to
5e1c572
Compare
9dd1158
to
9390926
Compare
Base automatically changed from
users/Akshat-Oke/09-27-_mir_serialize_virtual_register_flags
to
main
October 14, 2024 08:49
9390926
to
38a9c7b
Compare
Stylie777
pushed a commit
to Stylie777/llvm-project
that referenced
this pull request
Oct 14, 2024
The delegates' callback isn't invoked on parsing new virtual registers. There are two places in the serialization where new virtual registers can be discovered: in register infos and in instructions.
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
The delegates' callback isn't invoked on parsing new virtual registers. There are two places in the serialization where new virtual registers can be discovered: in register infos and in instructions.
bricknerb
pushed a commit
to bricknerb/llvm-project
that referenced
this pull request
Oct 17, 2024
The delegates' callback isn't invoked on parsing new virtual registers. There are two places in the serialization where new virtual registers can be discovered: in register infos and in instructions.
EricWF
pushed a commit
to efcs/llvm-project
that referenced
this pull request
Oct 22, 2024
The delegates' callback isn't invoked on parsing new virtual registers. There are two places in the serialization where new virtual registers can be discovered: in register infos and in instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delegates' callback isn't invoked on parsing new virtual registers.
There are two places in the serialization where new virtual registers can be discovered: in register infos and in instructions.