[lldb] Check for Python 'packaging' module at configuration time #111747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module is used in various helper scripts since llvm#93712
|
@llvm/pr-subscribers-lldb Author: Stefan Gränitz (weliveindetail) ChangesThis module is used in various helper scripts since #93712 Full diff: https://github.com/llvm/llvm-project/pull/111747.diff 1 Files Affected:
diff --git a/lldb/test/CMakeLists.txt b/lldb/test/CMakeLists.txt
index 5ac474736eb63d..ceec782f19f4c7 100644
--- a/lldb/test/CMakeLists.txt
+++ b/lldb/test/CMakeLists.txt
@@ -12,7 +12,7 @@ endif()
if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
message(STATUS "Enforcing strict test requirements for LLDB")
# Lit uses psutil to do per-test timeouts.
- set(useful_python_modules psutil)
+ set(useful_python_modules psutil packaging)
if(NOT WIN32)
# We no longer vendor pexpect and it is not used on Windows.
|
bulbazord
approved these changes
Oct 9, 2024
JDevlieghere
approved these changes
Oct 9, 2024
|
No worries, we have it now. Thanks for the quick review! |
weliveindetail
added a commit
to weliveindetail/llvm-project
that referenced
this pull request
Oct 10, 2024
…m#111747) This module is used in various helper scripts since llvm#93712
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
…m#111747) This module is used in various helper scripts since llvm#93712
weliveindetail
added a commit
to weliveindetail/llvm-project
that referenced
this pull request
Oct 16, 2024
…m#111747) This module is used in various helper scripts since llvm#93712
weliveindetail
added a commit
to weliveindetail/llvm-project
that referenced
this pull request
Nov 5, 2024
…m#111747) This module is used in various helper scripts since llvm#93712
weliveindetail
added a commit
to weliveindetail/llvm-project
that referenced
this pull request
Nov 6, 2024
…m#111747) This module is used in various helper scripts since llvm#93712
weliveindetail
added a commit
to weliveindetail/llvm-project
that referenced
this pull request
Nov 27, 2024
…m#111747) This module is used in various helper scripts since llvm#93712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is used in various helper scripts since #93712