Fix CMake dependencies on mlir-linalg-ods-yaml-gen #111973

RoboTux · 2024-10-11T10:30:43Z

Fix a number of dependencies issue to build mlir-linalg-ods-yaml-gen
host binary which make a cross-build using the Make generator fail.
Namely:

do not use binary path for the custom target created when
LLVM_USE_HOST_TOOLS is true;
use target name instead of name of variable holding the target name
for add_custom_target and set_target_properties in setup_host_tool();
remove dependency on target defined in different directory in
add_linalg_ods_yaml_gen() since add_custom_target DEPENDS can only be
used on "files and outputs of custom commands created with
add_custom_command() command calls in the same directory";
remove unneeded dependency on ${MLIR_LINALG_ODS_YAML_GEN_EXE}, the
target dependency will ensure the binary will be built.

Note that we keep using ${MLIR_LINALG_ODS_YAML_GEN_EXE} in the COMMAND
rather than use ${MLIR_LINALG_ODS_YAML_GEN_TARGET} because when
LLVM_NATIVE_TOOL_DIR is used the latter is an empty string.

Testing-wise, all three codepaths in get_host_tool_path() were tested
with both GNU Make and Ninja generators:

cross-compiling with LLVM_NATIVE_TOOL_DIR checks the if path;
cross-compiling without LLVM_NATIVE_TOOL_DIR checks the elseif path;
native build without LLVM_NATIVE_TOOL_DIR checks the else path.

Fix a number of dependencies issue to build mlir-linalg-ods-yaml-gen host binary which make a cross-build using the Make generator fail. Namely: - do not use binary path for the custom target created when LLVM_USE_HOST_TOOLS is true; - use target name instead of name of variable holding the target name for add_custom_target and set_target_properties in setup_host_tool(); - remove dependency on target defined in different directory in add_linalg_ods_yaml_gen() since add_custom_target DEPENDS can only be used on "files and outputs of custom commands created with add_custom_command() command calls in the same directory"; - remove unneeded dependency on ${MLIR_LINALG_ODS_YAML_GEN_EXE}, the target dependency will ensure the binary will be built. Note that we keep using ${MLIR_LINALG_ODS_YAML_GEN_EXE} in the COMMAND rather than use ${MLIR_LINALG_ODS_YAML_GEN_TARGET} because when LLVM_NATIVE_TOOL_DIR is used the latter is an empty string. Testing-wise, all three codepaths in get_host_tool_path() were tested with both GNU Make and Ninja generators: - cross-compiling with LLVM_NATIVE_TOOL_DIR checks the if path; - cross-compiling without LLVM_NATIVE_TOOL_DIR checks the elseif path; - native build without LLVM_NATIVE_TOOL_DIR checks the else path.

llvmbot · 2024-10-11T10:31:16Z

@llvm/pr-subscribers-mlir-linalg

@llvm/pr-subscribers-mlir

Author: Thomas Preud'homme (RoboTux)

Changes

Fix a number of dependencies issue to build mlir-linalg-ods-yaml-gen
host binary which make a cross-build using the Make generator fail.
Namely:

do not use binary path for the custom target created when
LLVM_USE_HOST_TOOLS is true;
use target name instead of name of variable holding the target name
for add_custom_target and set_target_properties in setup_host_tool();
remove dependency on target defined in different directory in
add_linalg_ods_yaml_gen() since add_custom_target DEPENDS can only be
used on "files and outputs of custom commands created with
add_custom_command() command calls in the same directory";
remove unneeded dependency on ${MLIR_LINALG_ODS_YAML_GEN_EXE}, the
target dependency will ensure the binary will be built.

Note that we keep using ${MLIR_LINALG_ODS_YAML_GEN_EXE} in the COMMAND
rather than use ${MLIR_LINALG_ODS_YAML_GEN_TARGET} because when
LLVM_NATIVE_TOOL_DIR is used the latter is an empty string.

Testing-wise, all three codepaths in get_host_tool_path() were tested
with both GNU Make and Ninja generators:

cross-compiling with LLVM_NATIVE_TOOL_DIR checks the if path;
cross-compiling without LLVM_NATIVE_TOOL_DIR checks the elseif path;
native build without LLVM_NATIVE_TOOL_DIR checks the else path.

Full diff: https://github.com/llvm/llvm-project/pull/111973.diff

2 Files Affected:

(modified) llvm/cmake/modules/AddLLVM.cmake (+3-3)
(modified) mlir/include/mlir/Dialect/Linalg/IR/CMakeLists.txt (-3)

diff --git a/llvm/cmake/modules/AddLLVM.cmake b/llvm/cmake/modules/AddLLVM.cmake
index c62b5649facae1..abffa3ec20386f 100644
--- a/llvm/cmake/modules/AddLLVM.cmake
+++ b/llvm/cmake/modules/AddLLVM.cmake
@@ -2618,7 +2618,7 @@ function(get_host_tool_path tool_name setting_name exe_var_name target_var_name)
     set(target_name "")
   elseif(LLVM_USE_HOST_TOOLS)
     get_native_tool_path(${tool_name} exe_name)
-    set(target_name ${exe_name})
+    set(target_name host_${tool_name})
   else()
     set(exe_name $<TARGET_FILE:${tool_name}>)
     set(target_name ${tool_name})
@@ -2632,8 +2632,8 @@ function(setup_host_tool tool_name setting_name exe_var_name target_var_name)
   # Set up a native tool build if necessary
   if(LLVM_USE_HOST_TOOLS AND NOT ${setting_name})
     build_native_tool(${tool_name} exe_name DEPENDS ${tool_name})
-    add_custom_target(${target_var_name} DEPENDS ${exe_name})
+    add_custom_target(${${target_var_name}} DEPENDS ${exe_name})
     get_subproject_title(subproject_title)
-    set_target_properties(${target_var_name} PROPERTIES FOLDER "${subproject_title}/Native")
+    set_target_properties(${${target_var_name}} PROPERTIES FOLDER "${subproject_title}/Native")
   endif()
 endfunction()
diff --git a/mlir/include/mlir/Dialect/Linalg/IR/CMakeLists.txt b/mlir/include/mlir/Dialect/Linalg/IR/CMakeLists.txt
index 289c0e4bbdaf68..71214b4404c550 100644
--- a/mlir/include/mlir/Dialect/Linalg/IR/CMakeLists.txt
+++ b/mlir/include/mlir/Dialect/Linalg/IR/CMakeLists.txt
@@ -15,13 +15,10 @@ function(add_linalg_ods_yaml_gen yaml_ast_file output_file)
     MAIN_DEPENDENCY
     ${YAML_AST_SOURCE}
     DEPENDS
-    ${MLIR_LINALG_ODS_YAML_GEN_EXE}
     ${MLIR_LINALG_ODS_YAML_GEN_TARGET})
   add_custom_target(
     MLIR${output_file}YamlIncGen
     DEPENDS
-    ${MLIR_LINALG_ODS_YAML_GEN_EXE}
-    ${MLIR_LINALG_ODS_YAML_GEN_TARGET}
     ${GEN_ODS_FILE} ${GEN_CPP_FILE})
   set_target_properties(MLIR${output_file}YamlIncGen PROPERTIES FOLDER "MLIR/Tablegenning")
   list(APPEND LLVM_TARGET_DEPENDS ${GEN_ODS_FILE})

igorkudrin · 2024-10-12T01:17:18Z

Changes in AddLLVM.cmake LGTM. I can't say anything about the other part.

omjavaid · 2024-10-14T01:24:27Z

Apparently these changes look fine to me. But someone aware with Dialects/Linalg project should approve.

stellaraccident

This looks ok to me. The way it was never looked right to me.

(We're trying to remove this piece entirely but it will take some time)

Fix a number of dependencies issue to build mlir-linalg-ods-yaml-gen host binary which make a cross-build using the Make generator fail. Namely: - do not use binary path for the custom target created when LLVM_USE_HOST_TOOLS is true; - use target name instead of name of variable holding the target name for add_custom_target and set_target_properties in setup_host_tool(); - remove dependency on target defined in different directory in add_linalg_ods_yaml_gen() since add_custom_target DEPENDS can only be used on "files and outputs of custom commands created with add_custom_command() command calls in the same directory"; - remove unneeded dependency on ${MLIR_LINALG_ODS_YAML_GEN_EXE}, the target dependency will ensure the binary will be built. Note that we keep using ${MLIR_LINALG_ODS_YAML_GEN_EXE} in the COMMAND rather than use ${MLIR_LINALG_ODS_YAML_GEN_TARGET} because when LLVM_NATIVE_TOOL_DIR is used the latter is an empty string. Testing-wise, all three codepaths in get_host_tool_path() were tested with both GNU Make and Ninja generators: - cross-compiling with LLVM_NATIVE_TOOL_DIR checks the if path; - cross-compiling without LLVM_NATIVE_TOOL_DIR checks the elseif path; - native build without LLVM_NATIVE_TOOL_DIR checks the else path.

tbaederr · 2024-10-14T10:27:43Z

This commit causes these errors when I configure:

-- Clang version: 20.0.0git
CMake Error at cmake/modules/AddLLVM.cmake:2635 (add_custom_target):
  add_custom_target called with invalid target name
  "/home/tbaeder/code/llvm-project/build/NATIVE/bin/clang".  Target names may
  not contain a slash.  Use ADD_CUSTOM_COMMAND to generate files.
Call Stack (most recent call first):
  /home/tbaeder/code/llvm-project/clang/tools/driver/CMakeLists.txt:41 (setup_host_tool)


CMake Error at cmake/modules/AddLLVM.cmake:2637 (set_target_properties):
  set_target_properties Can not find target to add properties to:
  /home/tbaeder/code/llvm-project/build/NATIVE/bin/clang
Call Stack (most recent call first):
  /home/tbaeder/code/llvm-project/clang/tools/driver/CMakeLists.txt:41 (setup_host_tool)


CMake Error at cmake/modules/AddLLVM.cmake:2635 (add_custom_target):
  add_custom_target called with invalid target name
  "/home/tbaeder/code/llvm-project/build/NATIVE/bin/llvm-as".  Target names
  may not contain a slash.  Use ADD_CUSTOM_COMMAND to generate files.
Call Stack (most recent call first):
  tools/llvm-as/CMakeLists.txt:15 (setup_host_tool)


CMake Error at cmake/modules/AddLLVM.cmake:2637 (set_target_properties):
  set_target_properties Can not find target to add properties to:
  /home/tbaeder/code/llvm-project/build/NATIVE/bin/llvm-as
Call Stack (most recent call first):
  tools/llvm-as/CMakeLists.txt:15 (setup_host_tool)


CMake Error at cmake/modules/AddLLVM.cmake:2635 (add_custom_target):
  add_custom_target called with invalid target name
  "/home/tbaeder/code/llvm-project/build/NATIVE/bin/llvm-link".  Target names
  may not contain a slash.  Use ADD_CUSTOM_COMMAND to generate files.
Call Stack (most recent call first):
  tools/llvm-link/CMakeLists.txt:21 (setup_host_tool)


CMake Error at cmake/modules/AddLLVM.cmake:2637 (set_target_properties):
  set_target_properties Can not find target to add properties to:
  /home/tbaeder/code/llvm-project/build/NATIVE/bin/llvm-link
Call Stack (most recent call first):
  tools/llvm-link/CMakeLists.txt:21 (setup_host_tool)


CMake Error at cmake/modules/AddLLVM.cmake:2635 (add_custom_target):
  add_custom_target called with invalid target name
  "/home/tbaeder/code/llvm-project/build/NATIVE/bin/llvm-nm".  Target names
  may not contain a slash.  Use ADD_CUSTOM_COMMAND to generate files.
Call Stack (most recent call first):
  tools/llvm-nm/CMakeLists.txt:29 (setup_host_tool)


CMake Error at cmake/modules/AddLLVM.cmake:2637 (set_target_properties):
  set_target_properties Can not find target to add properties to:
  /home/tbaeder/code/llvm-project/build/NATIVE/bin/llvm-nm
Call Stack (most recent call first):
  tools/llvm-nm/CMakeLists.txt:29 (setup_host_tool)


CMake Error at cmake/modules/AddLLVM.cmake:2635 (add_custom_target):
  add_custom_target called with invalid target name
  "/home/tbaeder/code/llvm-project/build/NATIVE/bin/llvm-readobj".  Target
  names may not contain a slash.  Use ADD_CUSTOM_COMMAND to generate files.
Call Stack (most recent call first):
  tools/llvm-readobj/CMakeLists.txt:33 (setup_host_tool)


CMake Error at cmake/modules/AddLLVM.cmake:2637 (set_target_properties):
  set_target_properties Can not find target to add properties to:
  /home/tbaeder/code/llvm-project/build/NATIVE/bin/llvm-readobj
Call Stack (most recent call first):
  tools/llvm-readobj/CMakeLists.txt:33 (setup_host_tool)


CMake Error at cmake/modules/AddLLVM.cmake:2635 (add_custom_target):
  add_custom_target called with invalid target name
  "/home/tbaeder/code/llvm-project/build/NATIVE/bin/opt".  Target names may
  not contain a slash.  Use ADD_CUSTOM_COMMAND to generate files.
Call Stack (most recent call first):
  tools/opt/CMakeLists.txt:53 (setup_host_tool)


CMake Error at cmake/modules/AddLLVM.cmake:2637 (set_target_properties):
  set_target_properties Can not find target to add properties to:
  /home/tbaeder/code/llvm-project/build/NATIVE/bin/opt
Call Stack (most recent call first):
  tools/opt/CMakeLists.txt:53 (setup_host_tool)


-- Configuring incomplete, errors occurred!

Reverting the patch makes things work again.

RoboTux · 2024-10-14T10:57:38Z

Ack, I'll revert until I figure out what's the problem.

This reverts commit d6827f6 due to the following CMake configure failure being observed by some: add_custom_target called with invalid target name

…)" This reverts commit d6827f6.

RoboTux · 2024-10-14T12:10:38Z

@tbaederr Was it an incremental build? With this patch the target name should be ${tool_name}, i.e. clang. However it is set in that way:
set(${target_var_name} "${target_name}" CACHE STRING "")
So I wonder if you had an old value in the cache.

tbaederr · 2024-10-14T13:13:22Z

Yes, it was my local build. A ninja clean didn't help either, but I guess that doesn't nuke the cache(?)

RoboTux · 2024-10-14T13:25:36Z

I'm guessing it does not. I could change the variable to not be a cache variable. @mstorsjo Is there a reason why get_host_tool_path() sets the executable and target variables as cache? It seems to me to be build system internals.

mstorsjo · 2024-10-14T13:33:19Z

I'm guessing it does not. I could change the variable to not be a cache variable. @mstorsjo Is there a reason why get_host_tool_path() sets the executable and target variables as cache? It seems to me to be build system internals.

Earlier, if users wanted to use a prebuilt e.g. llvm-tblgen (e.g. when cross compiling), they'd set -DLLVM_TBLGEN=/path/to/binary - so I think that's why those variables traditionally were cache variables. Since introducing LLVM_NATIVE_TOOL_DIR there's less reason to set those individually, but I guess we haven't officially deprecated/removed the old way of doing that.

RoboTux · 2024-10-14T14:38:48Z

I'm guessing it does not. I could change the variable to not be a cache variable. @mstorsjo Is there a reason why get_host_tool_path() sets the executable and target variables as cache? It seems to me to be build system internals.

Earlier, if users wanted to use a prebuilt e.g. llvm-tblgen (e.g. when cross compiling), they'd set -DLLVM_TBLGEN=/path/to/binary - so I think that's why those variables traditionally were cache variables. Since introducing LLVM_NATIVE_TOOL_DIR there's less reason to set those individually, but I guess we haven't officially deprecated/removed the old way of doing that.

Are you talking about LLVM_TABLEGEN? That seems like a different thing because if I try to trace all calls to get_host_tool_path it seems the cache variable it looks for are named:

clang_target
clang_tidy_confusable_chars_gen_target
llvm-as_target
llvm_as_target
llvm-link_target
llvm_link_target
llvm_nm_target
llvm_readobj_target
opt_target
prepare_builtins_target
MLIR_LINALG_ODS_YAML_GEN_TARGET

I'm tempted to make it a non cache variable because the only alternative I can think of is to tell people to nuke their existing build if they encounter issues.

mstorsjo · 2024-10-14T14:55:35Z

I'm guessing it does not. I could change the variable to not be a cache variable. @mstorsjo Is there a reason why get_host_tool_path() sets the executable and target variables as cache? It seems to me to be build system internals.

Earlier, if users wanted to use a prebuilt e.g. llvm-tblgen (e.g. when cross compiling), they'd set -DLLVM_TBLGEN=/path/to/binary - so I think that's why those variables traditionally were cache variables. Since introducing LLVM_NATIVE_TOOL_DIR there's less reason to set those individually, but I guess we haven't officially deprecated/removed the old way of doing that.

Are you talking about LLVM_TABLEGEN? That seems like a different thing because if I try to trace all calls to get_host_tool_path it seems the cache variable it looks for are named:

Yes, that's the one I meant. Sorry, I didn't have time to dig in closer what this really was touching.

clang_target

clang_tidy_confusable_chars_gen_target

llvm-as_target

llvm_as_target

llvm-link_target

llvm_link_target

llvm_nm_target

llvm_readobj_target

opt_target

prepare_builtins_target

MLIR_LINALG_ODS_YAML_GEN_TARGET

I'm tempted to make it a non cache variable because the only alternative I can think of is to tell people to nuke their existing build if they encounter issues.

Indeed, I don't see any reason to keep those variables as CACHE variables.

Fix a number of dependencies issue to build mlir-linalg-ods-yaml-gen host binary which make a cross-build using the Make generator fail. Namely: - do not use binary path for the custom target created when LLVM_USE_HOST_TOOLS is true; - use target name instead of name of variable holding the target name for add_custom_target and set_target_properties in setup_host_tool(); - remove dependency on target defined in different directory in add_linalg_ods_yaml_gen() since add_custom_target DEPENDS can only be used on "files and outputs of custom commands created with add_custom_command() command calls in the same directory"; - remove unneeded dependency on ${MLIR_LINALG_ODS_YAML_GEN_EXE}, the target dependency will ensure the binary will be built. Note that we keep using ${MLIR_LINALG_ODS_YAML_GEN_EXE} in the COMMAND rather than use ${MLIR_LINALG_ODS_YAML_GEN_TARGET} because when LLVM_NATIVE_TOOL_DIR is used the latter is an empty string. Testing-wise, all three codepaths in get_host_tool_path() were tested with both GNU Make and Ninja generators: - cross-compiling with LLVM_NATIVE_TOOL_DIR checks the if path; - cross-compiling without LLVM_NATIVE_TOOL_DIR checks the elseif path; - native build without LLVM_NATIVE_TOOL_DIR checks the else path.

RoboTux · 2024-10-14T15:45:55Z

I've respinned the PR to make cache variable regular variable instead in #112224

llvm-ci · 2024-10-14T15:47:23Z

LLVM Buildbot has detected a new failure on builder lld-x86_64-win running on as-worker-93 while building llvm,mlir at step 7 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/1376

Here is the relevant piece of the build log for the reference

Step 7 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM-Unit :: Support/./SupportTests.exe/35/87' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe-LLVM-Unit-19816-35-87.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=87 GTEST_SHARD_INDEX=35 C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe
--

Script:
--
C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe --gtest_filter=ProgramEnvTest.CreateProcessLongPath
--
C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(160): error: Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(163): error: fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied



C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:160
Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:163
fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied




********************

Fix a number of dependencies issue to build mlir-linalg-ods-yaml-gen host binary which make a cross-build using the Make generator fail. Namely: - do not use binary path for the custom target created when LLVM_USE_HOST_TOOLS is true; - use target name instead of name of variable holding the target name for add_custom_target and set_target_properties in setup_host_tool(); - remove dependency on target defined in different directory in add_linalg_ods_yaml_gen() since add_custom_target DEPENDS can only be used on "files and outputs of custom commands created with add_custom_command() command calls in the same directory"; - remove unneeded dependency on ${MLIR_LINALG_ODS_YAML_GEN_EXE}, the target dependency will ensure the binary will be built. Note that we keep using ${MLIR_LINALG_ODS_YAML_GEN_EXE} in the COMMAND rather than use ${MLIR_LINALG_ODS_YAML_GEN_TARGET} because when LLVM_NATIVE_TOOL_DIR is used the latter is an empty string. Testing-wise, all three codepaths in get_host_tool_path() were tested with both GNU Make and Ninja generators: - cross-compiling with LLVM_NATIVE_TOOL_DIR checks the if path; - cross-compiling without LLVM_NATIVE_TOOL_DIR checks the elseif path; - native build without LLVM_NATIVE_TOOL_DIR checks the else path.

…)" This reverts commit d6827f6 due to the following CMake configure failure being observed by some: add_custom_target called with invalid target name

Fix a number of dependencies issue to build mlir-linalg-ods-yaml-gen host binary which make a cross-build using the Make generator fail. Namely: - do not use binary path for the custom target created when LLVM_USE_HOST_TOOLS is true; - use target name instead of name of variable holding the target name for add_custom_target and set_target_properties in setup_host_tool(); - remove dependency on target defined in different directory in add_linalg_ods_yaml_gen() since add_custom_target DEPENDS can only be used on "files and outputs of custom commands created with add_custom_command() command calls in the same directory"; - remove unneeded dependency on ${MLIR_LINALG_ODS_YAML_GEN_EXE}, the target dependency will ensure the binary will be built. Note that we keep using ${MLIR_LINALG_ODS_YAML_GEN_EXE} in the COMMAND rather than use ${MLIR_LINALG_ODS_YAML_GEN_TARGET} because when LLVM_NATIVE_TOOL_DIR is used the latter is an empty string. Testing-wise, all three codepaths in get_host_tool_path() were tested with both GNU Make and Ninja generators: - cross-compiling with LLVM_NATIVE_TOOL_DIR checks the if path; - cross-compiling without LLVM_NATIVE_TOOL_DIR checks the elseif path; - native build without LLVM_NATIVE_TOOL_DIR checks the else path.

…)" This reverts commit d6827f6 due to the following CMake configure failure being observed by some: add_custom_target called with invalid target name

Fix a number of dependencies issue to build mlir-linalg-ods-yaml-gen host binary which make a cross-build using the Make generator fail. Namely: - do not use binary path for the custom target created when LLVM_USE_HOST_TOOLS is true; - use target name instead of name of variable holding the target name for add_custom_target and set_target_properties in setup_host_tool(); - remove dependency on target defined in different directory in add_linalg_ods_yaml_gen() since add_custom_target DEPENDS can only be used on "files and outputs of custom commands created with add_custom_command() command calls in the same directory"; - remove unneeded dependency on ${MLIR_LINALG_ODS_YAML_GEN_EXE}, the target dependency will ensure the binary will be built. Note that we keep using ${MLIR_LINALG_ODS_YAML_GEN_EXE} in the COMMAND rather than use ${MLIR_LINALG_ODS_YAML_GEN_TARGET} because when LLVM_NATIVE_TOOL_DIR is used the latter is an empty string. Testing-wise, all three codepaths in get_host_tool_path() were tested with both GNU Make and Ninja generators: - cross-compiling with LLVM_NATIVE_TOOL_DIR checks the if path; - cross-compiling without LLVM_NATIVE_TOOL_DIR checks the elseif path; - native build without LLVM_NATIVE_TOOL_DIR checks the else path.

…)" This reverts commit d6827f6 due to the following CMake configure failure being observed by some: add_custom_target called with invalid target name

RoboTux requested review from dcaballe, nicolasvasilache and rengolin as code owners October 11, 2024 10:30

llvmbot added cmake Build system in general and CMake in particular mlir:linalg mlir labels Oct 11, 2024

RoboTux requested review from mstorsjo, igorkudrin and omjavaid October 11, 2024 10:32

stellaraccident approved these changes Oct 14, 2024

View reviewed changes

RoboTux merged commit d6827f6 into llvm:main Oct 14, 2024
12 checks passed

tbaederr added a commit to tbaederr/llvm-project that referenced this pull request Oct 14, 2024

Revert "Fix CMake dependencies on mlir-linalg-ods-yaml-gen (llvm#111973…

7cbcb44

…)" This reverts commit d6827f6.

RoboTux mentioned this pull request Oct 14, 2024

Fix CMake dependencies on mlir-linalg-ods-yaml-gen #112224

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CMake dependencies on mlir-linalg-ods-yaml-gen #111973

Fix CMake dependencies on mlir-linalg-ods-yaml-gen #111973

RoboTux commented Oct 11, 2024

llvmbot commented Oct 11, 2024 •

edited

Loading

igorkudrin commented Oct 12, 2024

omjavaid commented Oct 14, 2024

stellaraccident left a comment

tbaederr commented Oct 14, 2024

RoboTux commented Oct 14, 2024

RoboTux commented Oct 14, 2024

tbaederr commented Oct 14, 2024

RoboTux commented Oct 14, 2024

mstorsjo commented Oct 14, 2024

RoboTux commented Oct 14, 2024

mstorsjo commented Oct 14, 2024

RoboTux commented Oct 14, 2024

llvm-ci commented Oct 14, 2024

Fix CMake dependencies on mlir-linalg-ods-yaml-gen #111973

Fix CMake dependencies on mlir-linalg-ods-yaml-gen #111973

Conversation

RoboTux commented Oct 11, 2024

llvmbot commented Oct 11, 2024 • edited Loading

igorkudrin commented Oct 12, 2024

omjavaid commented Oct 14, 2024

stellaraccident left a comment

Choose a reason for hiding this comment

tbaederr commented Oct 14, 2024

RoboTux commented Oct 14, 2024

RoboTux commented Oct 14, 2024

tbaederr commented Oct 14, 2024

RoboTux commented Oct 14, 2024

mstorsjo commented Oct 14, 2024

RoboTux commented Oct 14, 2024

mstorsjo commented Oct 14, 2024

RoboTux commented Oct 14, 2024

llvm-ci commented Oct 14, 2024

llvmbot commented Oct 11, 2024 •

edited

Loading