[lldb][AIX] Added support for AIX in HostInfo section

[Lakshmi-Surekha]

This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
   Extending LLDB to work on AIX #101657
2. The complete changes for porting are present in this draft PR:
   Extending LLDB to work on AIX #102601
   Added support for AIX in HostInfo section

Review Request : @DavidSpickett @labath @DhruvSrivastavaX

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: None (Lakshmi-Surekha)

Changes

This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
#101657
The complete changes for porting are present in this draft PR:
#102601
Added support for AIX in HostInfo section

@DavidSpickett @labath @DhruvSrivastavaX

---

Full diff: https://github.com/llvm/llvm-project/pull/122301.diff

1 Files Affected:

• (modified) lldb/include/lldb/Host/HostInfo.h (+3)

diff --git a/lldb/include/lldb/Host/HostInfo.h b/lldb/include/lldb/Host/HostInfo.h
index b7010d69d88e7f..0f7ec0e0aa0d24 100644
--- a/lldb/include/lldb/Host/HostInfo.h
+++ b/lldb/include/lldb/Host/HostInfo.h
@@ -55,6 +55,9 @@
 #elif defined(__APPLE__)
 #include "lldb/Host/macosx/HostInfoMacOSX.h"
 #define HOST_INFO_TYPE HostInfoMacOSX
+#elif defined(_AIX)
+#include "lldb/Host/aix/HostInfoAIX.h"
+#define HOST_INFO_TYPE HostInfoAIX
 #else
 #include "lldb/Host/posix/HostInfoPosix.h"
 #define HOST_INFO_TYPE HostInfoPosix

[DhruvSrivastavaX]

Note that HostInfoAIX has already been created via this PR:

• [lldb][AIX] HostInfoAIX Support  #117906

[DavidSpickett]

LGTM.

[github-actions]

@Lakshmi-Surekha Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

[DavidSpickett]

In future, please remember to remove anything from the commit message that was purely for the review process, or generally no longer applies to the code being landed. GitHub gives you a chance to do this just before the PR is merged.

In this case it just meant I got an extra ping when this landed by being @ in the commit message, so no big deal.

[DhruvSrivastavaX]

In future, please remember to remove anything from the commit message that was purely for the review process, or generally no longer applies to the code being landed. GitHub gives you a chance to do this just before the PR is merged.

In this case it just meant I got an extra ping when this landed by being @ in the commit message, so no big deal.

Okay, Thanks for informing!
I was actually unsure whether I should change the original message or not. Will change from next PR onwards.

[DavidSpickett]

This is actually a common point of confusion, the LLVM repo is setup to create the final commit message from the PR description, not the commit(s) message(s) in the PR itself. I guess because A: the PR description is easier to edit and B: we always squash before merging, so the combination of the commit messages rarely makes any sense.

So when you merge, GitHub starts with the PR description, then lets you edit from there, but it doesn't write back any changes to the PR description. So you can leave it as is if you want to.

The main thing to think about is: would anything here mislead a future reader?

And for this PR no, it's just a few extra GitHub pings. But for example if you posted a PR to do X but were persuaded by reviewers to do !X, it will save confusion later if you update the descriptions.

And if you do push some misleading commit message (we all do it sometimes) you can always leave comments on the PR. We do that for reverts and post commit review also.

[DavidSpickett]

You can never 100% trust anything that isn't the code (and even then, be careful), but it is nice when the descriptions are at least helpful.

[DhruvSrivastavaX]

Okay great. Thanks for explaining that!
I'll make sure that the final story reads well. (Especially if we go from X to !X 🙂 )
And its always a plus to add footnotes to the post-merge discussion in such cases.