-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Coroutine][DebugInfo] Remove the memory attributes on coro-async-declaration.ll (NFC) #66088
Merged
DianQK
merged 2 commits into
llvm:main
from
DianQK:remove-memory-attrs-for-coro-async-test
Sep 14, 2023
Merged
[Coroutine][DebugInfo] Remove the memory attributes on coro-async-declaration.ll (NFC) #66088
DianQK
merged 2 commits into
llvm:main
from
DianQK:remove-memory-attrs-for-coro-async-test
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-coroutines ChangesAccording to @drodriguez's reminder in swiftlang#7168 (comment), And this is irrelevant to that test. Delete to get better a test case.Full diff: https://github.com/llvm/llvm-project/pull/66088.diff 1 Files Affected:
diff --git a/llvm/test/Transforms/Coroutines/coro-async-declaration.ll b/llvm/test/Transforms/Coroutines/coro-async-declaration.ll index 3cac3c167df3b09..562f89b6981dca2 100644 --- a/llvm/test/Transforms/Coroutines/coro-async-declaration.ll +++ b/llvm/test/Transforms/Coroutines/coro-async-declaration.ll @@ -28,7 +28,6 @@ entry: %4 = load i32, ptr getelementptr inbounds (%swift.async_func_pointer, ptr @"$s3foo1fyyYaFTu", i32 0, i32 1), align 8, !dbg !10 %5 = zext i32 %4 to i64, !dbg !10 %6 = call swiftcc ptr @swift_task_alloc(i64 %5), !dbg !10 - call void @llvm.lifetime.start.p0(i64 -1, ptr %6), !dbg !10 %7 = load ptr, ptr %1, align 8, !dbg !10 %8 = getelementptr inbounds <{ ptr, ptr }>, ptr %6, i32 0, i32 0, !dbg !10 store ptr %7, ptr %8, align 8, !dbg !10 @@ -40,7 +39,6 @@ entry: %13 = call ptr @__swift_async_resume_project_context(ptr %12), !dbg !10 store ptr %13, ptr %1, align 8, !dbg !10 call swiftcc void @swift_task_dealloc(ptr %6), !dbg !10 - call void @llvm.lifetime.end.p0(i64 -1, ptr %6), !dbg !10 %14 = load ptr, ptr %1, align 8, !dbg !11 %15 = getelementptr inbounds <{ ptr, ptr }>, ptr %14, i32 0, i32 1, !dbg !11 %16 = load ptr, ptr %15, align 8, !dbg !11 @@ -52,9 +50,6 @@ entry: ; Function Attrs: nounwind declare token @llvm.coro.id.async(i32, i32, i32, ptr) #0 -; Function Attrs: cold noreturn nounwind memory(inaccessiblemem: write) -declare void @llvm.trap() #1 - ; Function Attrs: nounwind declare ptr @llvm.coro.begin(token, ptr writeonly) #0 @@ -62,9 +57,6 @@ declare swifttailcc void @"$s3foo1fyyYaF"(ptr swiftasync) declare swiftcc ptr @swift_task_alloc(i64) -; Function Attrs: nocallback nofree nosync nounwind willreturn memory(argmem: readwrite) -declare void @llvm.lifetime.start.p0(i64 immarg, ptr nocapture) #2 - ; Function Attrs: nomerge nounwind declare ptr @llvm.coro.async.resume() #3 @@ -86,13 +78,10 @@ entry: } ; Function Attrs: nomerge nounwind -declare { ptr } @llvm.coro.suspend.async.sl_p0s(i32, ptr, ptr, ...) #3 +declare { ptr } @llvm.coro.suspend.async.sl_p0s(i32, ptr, ptr, ...) #1 declare swiftcc void @swift_task_dealloc(ptr) -; Function Attrs: nocallback nofree nosync nounwind willreturn memory(argmem: readwrite) -declare void @llvm.lifetime.end.p0(i64 immarg, ptr nocapture) #2 - define internal swifttailcc void @"$s3foo3FooO3baryyYaF.0.1"(ptr %0, ptr %1) !dbg !17 { entry: musttail call swifttailcc void %0(ptr swiftasync %1), !dbg !18 @@ -103,9 +92,7 @@ entry: declare i1 @llvm.coro.end.async(ptr, i1, ...) #0 attributes #0 = { nounwind } -attributes #1 = { cold noreturn nounwind memory(inaccessiblemem: write) } -attributes #2 = { nocallback nofree nosync nounwind willreturn memory(argmem: readwrite) } -attributes #3 = { nomerge nounwind } +attributes #1 = { nomerge nounwind } !llvm.dbg.cu = !{!0} !llvm.module.flags = !{!3, !4} |
…laration.ll (NFC) This is irrelevant to that test. It also breaks the backport to the apple branch.
a49ed25
to
993f0ef
Compare
felipepiovezan
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ync-declaration.ll (NFC) Fix typo
The failure on windows should be irrelevant. |
kstoimenov
pushed a commit
to kstoimenov/llvm-project
that referenced
this pull request
Sep 14, 2023
…laration.ll (NFC) (llvm#66088) According to @drodriguez's reminder in swiftlang#7168 (comment), `memory` breaks the backport to the apple branch. And this is irrelevant to that test. Delete to get better a test case.
This was referenced Sep 14, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…laration.ll (NFC) (llvm#66088) According to @drodriguez's reminder in swiftlang#7168 (comment), `memory` breaks the backport to the apple branch. And this is irrelevant to that test. Delete to get better a test case.
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Sep 21, 2023
Local branch amd-gfx f205aef Merged main:87e11ecbaec9 into amd-gfx:e761c8ea3c3a Remote branch main 19b664d [Coroutine][DebugInfo] Remove the memory attributes on coro-async-declaration.ll (NFC) (llvm#66088)
felipepiovezan
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 22, 2023
…laration.ll (NFC) (llvm#66088) According to @drodriguez's reminder in #7168 (comment), `memory` breaks the backport to the apple branch. And this is irrelevant to that test. Delete to get better a test case. (cherry picked from commit 19b664d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @drodriguez's reminder in swiftlang#7168 (comment),
memory
breaks the backport to the apple branch.And this is irrelevant to that test. Delete to get better a test case.