Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[analyzer] Improve diagnostics from ArrayBoundCheckerV2 #70056

Merged
merged 5 commits into from
Nov 7, 2023

Commits on Oct 24, 2023

  1. [analyzer] Improve reports from ArrayBoundCheckerV2

    Previously alpha.security.ArrayBoundV2 produced very spartan bug
    reports; this commit ensures that the relevant (and known) details are
    reported to the user.
    
    The logic for detecting bugs is not changed, after this commit the
    checker will report the same set of issues, but with better messages.
    
    To test the details of the message generation this commit adds a new
    test file 'out-of-bounds-diagnostics.c'. Three of the testcases are
    added with FIXME notes because they reveal shortcomings of the existing
    modeling and bounds checking code. I will try to fix them in separate
    follow-up commits.
    NagyDonat committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    77143e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    ffd3edb View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Configuration menu
    Copy the full SHA
    64c5ffe View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    979a387 View commit details
    Browse the repository at this point in the history
  2. Revert "Make the message for tainted offsets more general"

    I thought for a moment that there are some corner cases where the more
    specific "may be too large" message is inaccurate, but I realized that
    there are no such cases, so we can use the specific message (which is
    slightly more helpful for the user).
    
    This reverts commit 979a387.
    NagyDonat committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    d2914b3 View commit details
    Browse the repository at this point in the history