Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeGen][MachineVerifier] Use TypeSize instead of unsigned for getRe… #70881

Merged
merged 6 commits into from
Nov 7, 2023
Merged

[CodeGen][MachineVerifier] Use TypeSize instead of unsigned for getRe… #70881

merged 6 commits into from
Nov 7, 2023

Commits on Nov 3, 2023

  1. [CodeGen][MachineVerifier] Use TypeSize instead of unsigned for getRe… 

    …gSizeInBits

This patch changes getRegSizeInBits to return a TypeSize instead of an
unsigned in the case that a virtual register has a scalable LLT. In the
case that register is physical, a Fixed TypeSize is returned.

The MachineVerifier pass is updated to allow copies between fixed and
scalable operands as long as the Src size will fit into the Dest size.

This is a precommit which will be stacked on by a change to GISel to
generate COPYs with a scalable destination but a fixed size source.
    @michaelmaitland
    michaelmaitland committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    8c0577a View commit details
    Browse the repository at this point in the history

  2. Avoid duplicate computation

    @michaelmaitland
    michaelmaitland committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    7d1aace View commit details
    Browse the repository at this point in the history

  3. Add MachineVerifier test case

    @michaelmaitland
    michaelmaitland committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    166017c View commit details
    Browse the repository at this point in the history

  4. fix failing test

    @michaelmaitland
    michaelmaitland committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    0f0e8ab View commit details
    Browse the repository at this point in the history

  5. remove impossible case

    @michaelmaitland
    michaelmaitland committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    10d2840 View commit details
    Browse the repository at this point in the history

  6. Only allow copy from physical -> virtual

    @michaelmaitland
    michaelmaitland committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    624c945 View commit details
    Browse the repository at this point in the history