Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb][AArch64] Move register info reconfigure into architecture plugin #70950

Merged
merged 1 commit into from
Nov 6, 2023

Commits on Nov 2, 2023

  1. [lldb][AArch64] Move register info reconfigure into architecture plugin

    This removes AArch64 specific code from the GDB* classes.
    
    To do this I've added 2 new methods to Architecture:
    * RegisterWriteCausesReconfigure to check if what you are about to do
      will trash the register info.
    * ReconfigureRegisterInfo to do the reconfiguring. This tells you if
      anything changed so that we only invalidate registers when needed.
    
    So that ProcessGDBRemote can call ReconfigureRegisterInfo in SetThreadStopInfo,
    I've added forwarding calls to GDBRemoteRegisterContext and the base class
    RegisterContext.
    
    (which removes a slightly sketchy static cast as well)
    
    RegisterContext defaults to doing nothing for both the methods
    so anything other than GDBRemoteRegisterContext will do nothing.
    DavidSpickett committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    47a4874 View commit details
    Browse the repository at this point in the history