Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[indvars] Always fallback to truncation if AddRec widening fails #70967

Merged
merged 2 commits into from
Nov 7, 2023
Merged

[indvars] Always fallback to truncation if AddRec widening fails #70967

merged 2 commits into from
Nov 7, 2023

Commits on Nov 7, 2023

  1. [indvars] Always fallback to truncation if AddRec widening fails 

    The current code structure results in cases where if a) we can't clone the
IV user (because it's not in our whitelist) or b) can't prove the SCEV
expressions are identical, we'd sometimes leave both the original unwiddened
IV and the partially widdened IV in code.  Instead, just truncate thw wide
IV to the use - same as what we'd do if we couldn't find an addrec to start
with.

Noticed this while playing with changing how we produce addrecs.  The
current structure results in a very tight interlock between SCEVs
internal capabilities and indvars code.
    @preames
    preames committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    fb66e1f View commit details
    Browse the repository at this point in the history

  2. Test updates after rebase

    @preames
    preames committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    7b5f587 View commit details
    Browse the repository at this point in the history