-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test][llvm-objdump][AArch64] Add tests for ELF AUTH constants #74298
Conversation
@llvm/pr-subscribers-llvm-binary-utilities @llvm/pr-subscribers-backend-aarch64 Author: Daniil Kovalev (kovdan01) ChangesThis patch introduces llvm-objdump tests for new Full diff: https://github.com/llvm/llvm-project/pull/74298.diff 1 Files Affected:
diff --git a/llvm/test/tools/llvm-objdump/ELF/dynamic-section-machine-specific.test b/llvm/test/tools/llvm-objdump/ELF/dynamic-section-machine-specific.test
index 20219dd4893b7..203c210eb46a3 100644
--- a/llvm/test/tools/llvm-objdump/ELF/dynamic-section-machine-specific.test
+++ b/llvm/test/tools/llvm-objdump/ELF/dynamic-section-machine-specific.test
@@ -268,6 +268,9 @@ ProgramHeaders:
# AARCH64: Dynamic Section:
# AARCH64-NEXT: AARCH64_BTI_PLT 0x0000000000000001
# AARCH64-NEXT: AARCH64_PAC_PLT 0x0000000000000002
+# AARCH64-NEXT: AARCH64_AUTH_RELR 0x0000000000000003
+# AARCH64-NEXT: AARCH64_AUTH_RELRSZ 0x0000000000000004
+# AARCH64-NEXT: AARCH64_AUTH_RELRENT 0x0000000000000005
--- !ELF
FileHeader:
@@ -283,6 +286,12 @@ Sections:
Value: 1
- Tag: DT_AARCH64_PAC_PLT
Value: 2
+ - Tag: DT_AARCH64_AUTH_RELR
+ Value: 3
+ - Tag: DT_AARCH64_AUTH_RELRSZ
+ Value: 4
+ - Tag: DT_AARCH64_AUTH_RELRENT
+ Value: 5
- Tag: DT_NULL
Value: 0
ProgramHeaders:
|
I'd omit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too.
474b424
to
d06f0eb
Compare
Thanks, updated the commit message as suggested, force-pushed the new one. |
This patch introduces llvm-objdump tests for new `AARCH64_AUTH_RELR`, `AARCH64_AUTH_RELRSZ` and `AARCH64_AUTH_RELRENT` dynamic tags.
d06f0eb
to
e2c24e8
Compare
Rebased and force-pushed to trigger buildkite (builds were red previously since being dependent on #74874). @metaflow As far as I understood, there is currently no way to trigger pre-merge checks without updating the branch - please provide a way for that since updating the branch via rebase + force-push when the build fails due to unrelated reasons clutters review history. Thanks! |
I think rebasing while keeping all the incremental changes as "Commits" in the tab does not seem to clutter review history. |
This patch introduces llvm-objdump tests for new
AARCH64_AUTH_RELR
,AARCH64_AUTH_RELRSZ
andAARCH64_AUTH_RELRENT
dynamic tags.Depends on #74874