[github] Enable assertions on test workflow

[sudonatalie]

No description provided.

[llvmbot]

@llvm/pr-subscribers-github-workflow

Author: Natalie Chouinard (sudonatalie)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/74849.diff

1 Files Affected:

• (modified) .github/workflows/llvm-project-tests.yml (+1-1)

diff --git a/.github/workflows/llvm-project-tests.yml b/.github/workflows/llvm-project-tests.yml
index 6751bde4a11a9..02b1ab75e960e 100644
--- a/.github/workflows/llvm-project-tests.yml
+++ b/.github/workflows/llvm-project-tests.yml
@@ -96,7 +96,7 @@ jobs:
           # This should be a no-op for non-mac OSes
           PKG_CONFIG_PATH: /usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig//12
         with:
-          cmake_args: '-GNinja -DLLVM_ENABLE_PROJECTS="${{ inputs.projects }}" -DCMAKE_BUILD_TYPE=Release -DLLDB_INCLUDE_TESTS=OFF -DCMAKE_C_COMPILER_LAUNCHER=sccache -DCMAKE_CXX_COMPILER_LAUNCHER=sccache ${{ inputs.extra_cmake_args }}'
+          cmake_args: '-GNinja -DLLVM_ENABLE_PROJECTS="${{ inputs.projects }}" -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLDB_INCLUDE_TESTS=OFF -DCMAKE_C_COMPILER_LAUNCHER=sccache -DCMAKE_CXX_COMPILER_LAUNCHER=sccache ${{ inputs.extra_cmake_args }}'
           build_target: '${{ inputs.build_target }}'
 
       - name: Build and Test libclc

[sudonatalie]

@tstellar A couple SPIR-V backend tests are XFAILed due to hitting assertions, so they're unexpectedly passing on the bot. We could change this for just SPIR-V tests but I'm presuming this is the preferred default for most others too?

[tstellar]

@tstellar A couple SPIR-V backend tests are XFAILed due to hitting assertions, so they're unexpectedly passing on the bot. We could change this for just SPIR-V tests but I'm presuming this is the preferred default for most others too?

I think the correct way to fix this is to add REQUIRES: asserts to the tests.

[sudonatalie]

@tstellar A couple SPIR-V backend tests are XFAILed due to hitting assertions, so they're unexpectedly passing on the bot. We could change this for just SPIR-V tests but I'm presuming this is the preferred default for most others too?

I think the correct way to fix this is to add REQUIRES: asserts to the tests.

Ah, I'll make that change, thanks!

What do you think about enabling asserts anyways though? I would have expected that if a PR caused a passing test to hit an assert that it would cause that test to fail, and it looks like the LLVM Buildbot Infrastructure docs generally suggest "Release build types with Assertions enabled".

[tstellar]

I think if the buildbot guide recommends this then we should do it.