Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make two texts static in ReplayInlineAdvisor #79489

Merged
merged 1 commit into from
Jan 26, 2024

Commits on Jan 25, 2024

  1. Make two texts static in ReplayInlineAdvisor

    This commit makes two variables static.
    That makes two buildbot tests pass with short string annotations.
    
    Short string annotations PR (reverted):
    - llvm#79049
    
    Tests fixed with this PR:
    ``
      LLVM :: Transforms/Inline/cgscc-inline-replay.ll
      LLVM :: Transforms/SampleProfile/inline-replay.ll
    ```
    Buildbot output: https://lab.llvm.org/buildbot/#/builders/5/builds/40364/steps/9/logs/stdio
    
    This PR does not resolve a problem with `Clang :: SemaCXX/builtins.cpp`.
    
    I suspect that there may be use after end of life bug and it's fixed by this change.
    Advenam Tacet committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2746494 View commit details
    Browse the repository at this point in the history