[mlir][EmitC] Remove unused attribute from verbatim op #80142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-emitc @llvm/pr-subscribers-mlir Author: Simon Camphausen (simon-camp) ChangesThe uses of the attribute were removed in code review of #79584, but it's definition was inadvertently kept. Full diff: https://github.com/llvm/llvm-project/pull/80142.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
index ca040f2555e13..ada64f10a1675 100644
--- a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
+++ b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
@@ -574,10 +574,7 @@ def EmitC_VerbatimOp : EmitC_Op<"verbatim"> {
```
}];
- let arguments = (ins
- StrAttr:$value,
- UnitAttr:$trailing_semicolon
- );
+ let arguments = (ins StrAttr:$value);
let assemblyFormat = "$value attr-dict";
}
|
mgehre-amd
pushed a commit
to Xilinx/llvm-project
that referenced
this pull request
Mar 11, 2024
The uses of the attribute were removed in code review of llvm#79584, but it's definition was inadvertently kept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uses of the attribute were removed in code review of #79584, but it's definition was inadvertently kept.