Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflows] Only run code formatter on the main branch #80348

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

tstellar
Copy link
Collaborator

@tstellar tstellar commented Feb 1, 2024

Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches.

Further modifying a cherry-picked patch to fix code formatting issues
can be risky, so we don't typically do this.  Therefore, it's not
necessary to run this job on the release branches.
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 1, 2024

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches.


Full diff: https://github.com/llvm/llvm-project/pull/80348.diff

1 Files Affected:

  • (modified) .github/workflows/pr-code-format.yml (+3)
diff --git a/.github/workflows/pr-code-format.yml b/.github/workflows/pr-code-format.yml
index 5223089ee8a93..c8fd541fd34db 100644
--- a/.github/workflows/pr-code-format.yml
+++ b/.github/workflows/pr-code-format.yml
@@ -1,5 +1,8 @@
 name: "Check code formatting"
 on: pull_request_target
+  branches:
+    - main
+
 permissions:
   pull-requests: write
 

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reasoning makes sense to me, but not really familiar with release best practices.

Copy link
Collaborator

@tru tru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@tstellar tstellar merged commit 2193c95 into llvm:main Feb 4, 2024
5 checks passed
@tstellar tstellar added this to the LLVM 18.X Release milestone Feb 4, 2024
@tstellar
Copy link
Collaborator Author

tstellar commented Feb 4, 2024

/cherry-pick 2193c95

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 4, 2024
Modifying a cherry-picked patch to fix code formatting issues can be
risky, so we don't typically do this. Therefore, it's not necessary to
run this job on the release branches.

(cherry picked from commit 2193c95)
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 4, 2024

/pull-request #80585

agozillon pushed a commit to agozillon/llvm-project that referenced this pull request Feb 5, 2024
Modifying a cherry-picked patch to fix code formatting issues can be
risky, so we don't typically do this. Therefore, it's not necessary to
run this job on the release branches.
llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 6, 2024
Modifying a cherry-picked patch to fix code formatting issues can be
risky, so we don't typically do this. Therefore, it's not necessary to
run this job on the release branches.

(cherry picked from commit 2193c95)
llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 6, 2024
Modifying a cherry-picked patch to fix code formatting issues can be
risky, so we don't typically do this. Therefore, it's not necessary to
run this job on the release branches.

(cherry picked from commit 2193c95)
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 14, 2024
Modifying a cherry-picked patch to fix code formatting issues can be
risky, so we don't typically do this. Therefore, it's not necessary to
run this job on the release branches.

(cherry picked from commit 2193c95)
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 14, 2024
Modifying a cherry-picked patch to fix code formatting issues can be
risky, so we don't typically do this. Therefore, it's not necessary to
run this job on the release branches.

(cherry picked from commit 2193c95)
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 14, 2024
Modifying a cherry-picked patch to fix code formatting issues can be
risky, so we don't typically do this. Therefore, it's not necessary to
run this job on the release branches.

(cherry picked from commit 2193c95)
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 14, 2024
Modifying a cherry-picked patch to fix code formatting issues can be
risky, so we don't typically do this. Therefore, it's not necessary to
run this job on the release branches.

(cherry picked from commit 2193c95)
@pointhex pointhex mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants