Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++] Rename __bit_reference template parameter to avoid conflict #80661

Merged
merged 2 commits into from
Feb 5, 2024
Merged

[libc++] Rename __bit_reference template parameter to avoid conflict #80661

merged 2 commits into from
Feb 5, 2024

Commits on Feb 5, 2024

  1. [libc++] Rename __bit_reference template parameter to avoid conflict 

    As of 4d20cfc, `__bit_reference`
contains a template `__fill_n` with a bool `_FillValue` parameter.

Unfortunately there is a relatively widely used piece of scientific
software called NetCDF, which exposes a (C) macro `_FillValue` in its
public headers.

When building the NetCDF C++ bindings, this quickly leads to compilation
errors when the macro interferes with the template in `__bit_reference`.

Rename the parameter to `_Fill_Value` to avoid the conflict.
    @DimitryAndric
    DimitryAndric committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    17bd794 View commit details
    Browse the repository at this point in the history

  2. Rename _Fill_Value to _FillVal to keep the style.

    @DimitryAndric
    DimitryAndric committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    ff521d9 View commit details
    Browse the repository at this point in the history