Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[llvm-cov][CoverageView] minor fix/improvement to HTML and text coverage output #80952

Merged
merged 4 commits into from
Feb 17, 2024
Merged

[llvm-cov][CoverageView] minor fix/improvement to HTML and text coverage output #80952

merged 4 commits into from
Feb 17, 2024

Commits on Feb 7, 2024

  1. [llvm-cov][CoverageView] add the missing condition for MC/DC in hasSu… 

    …bViews()

Otherwise the generated HTML will place elements unpredictably. Most
notably, the MC/DC view boxes are often placed at the page top instead
of inline next to the actual code.
    @whentojump
    whentojump committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    fd726de View commit details
    Browse the repository at this point in the history

  2. [llvm-cov][CoverageViewHTML] add style for selected line 

    Highlight the selected line. One major benefit is, if the page is
relatively short, the line pointed by #Ln in URL may not be on top, and
this highlight can help quickly locate the line.
    @whentojump
    whentojump committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    40d5431 View commit details
    Browse the repository at this point in the history

  3. [llvm-cov][CoverageViewHTML] remove name="Ln" attribute in the link w… 

    …ithin MC/DC views

Or it would conflict with the link at actual lines and jumping via URLs
containing #Ln would fail
    @whentojump
    whentojump committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    22fb258 View commit details
    Browse the repository at this point in the history

  4. [llvm-cov][CoverageViewText] remove color for \n

    @whentojump
    whentojump committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    30a167d View commit details
    Browse the repository at this point in the history