Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on musl by including stdint.h #81434

Merged

Conversation

Calandracas606
Copy link
Contributor

openmp fails to build on musl since it lacks the defines for int32_t

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the openmp:libomptarget OpenMP offload runtime label Feb 11, 2024
@Calandracas606
Copy link
Contributor Author

Ping

Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good to me, but I'm not sure if this library has any other specific conventions, so looping in @shiltian as well.

@jdoerfert jdoerfert merged commit 45fe67d into llvm:main Feb 22, 2024
6 checks passed
Copy link

@Calandracas606 Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may recieve a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@shiltian
Copy link
Contributor

Do we want to use C header here instead of the C++ one?

@Calandracas606
Copy link
Contributor Author

it looks like both the C and C++ headers are used (sometimes both! see omptarget.h), but the C++ one appears to be more common.

I could open a new PR changing to the C++ header if preferred

@shiltian
Copy link
Contributor

Yeah, a patch to unify those headers would be great.

@MaskRay
Copy link
Member

MaskRay commented Feb 24, 2024

/cherry-pick 45fe67d

@MaskRay MaskRay added this to the LLVM 18.X Release milestone Feb 24, 2024
llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 24, 2024
openmp fails to build on musl since it lacks the defines for int32_t

Co-authored-by: Daniel Martinez <danielmartinez@cock.li>
(cherry picked from commit 45fe67d)
@llvmbot
Copy link
Member

llvmbot commented Feb 24, 2024

/pull-request #82897

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 26, 2024
openmp fails to build on musl since it lacks the defines for int32_t

Co-authored-by: Daniel Martinez <danielmartinez@cock.li>
(cherry picked from commit 45fe67d)
shiltian pushed a commit that referenced this pull request Mar 4, 2024
#81434

Replaced some C headers with C++ ones

Co-authored-by: Daniel Martinez <danielmartinez@cock.li>
@pointhex pointhex mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomptarget OpenMP offload runtime
Projects
Development

Successfully merging this pull request may close these issues.

6 participants