Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP][AIX] Set worker stack size to 2 x KMP_DEFAULT_STKSIZE if system stack size is too big #81996

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

xingxue-ibm
Copy link
Contributor

This patch sets the stack size of worker threads to 2 x KMP_DEFAULT_STKSIZE (2 x 4MB) for AIX if the system stack size is too big. Also defines maximum stack size for 32-bit AIX.

@xingxue-ibm xingxue-ibm added the openmp:libomp OpenMP host runtime label Feb 16, 2024
@xingxue-ibm xingxue-ibm self-assigned this Feb 16, 2024
@xingxue-ibm xingxue-ibm changed the title [OpenMp][AIX] Set worker stack size to 2 x KMP_DEFAULT_STKSIZE if system stack size is too big [OpenMP][AIX] Set worker stack size to 2 x KMP_DEFAULT_STKSIZE if system stack size is too big Feb 16, 2024
Copy link
Collaborator

@kkwli kkwli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@xingxue-ibm xingxue-ibm merged commit 2de269a into llvm:main Feb 16, 2024
6 checks passed
llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 18, 2024
…tem stack size is too big (llvm#81996)

This patch sets the stack size of worker threads to `2 x
KMP_DEFAULT_STKSIZE` (2 x 4MB) for AIX if the system stack size is too
big. Also defines maximum stack size for 32-bit AIX.

(cherry picked from commit 2de269a)
llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 20, 2024
…tem stack size is too big (llvm#81996)

This patch sets the stack size of worker threads to `2 x
KMP_DEFAULT_STKSIZE` (2 x 4MB) for AIX if the system stack size is too
big. Also defines maximum stack size for 32-bit AIX.

(cherry picked from commit 2de269a)
@pointhex pointhex mentioned this pull request May 7, 2024
@xingxue-ibm xingxue-ibm deleted the stack-size branch May 24, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants