Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLIR] [Transforms] Let lowerToLoopsUsingSCFForOp delete target op, fixes #83252 #83256

Closed
wants to merge 3 commits into from
Closed

[MLIR] [Transforms] Let lowerToLoopsUsingSCFForOp delete target op, fixes #83252 #83256

wants to merge 3 commits into from

Commits on Feb 28, 2024

  1. Let lowerToLoopsUsingSCFForOp delete target op. 

    The function mlir::scf::lowerToLoopsUsingSCFForOp was not deleting its
(structured) target op, resulting in IR with the expected loop nest in
front of the still remaining (structured) op, e.g. a linalg.matmul.
    @lhunloh
    lhunloh committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    2f1ef50 View commit details
    Browse the repository at this point in the history

  2. Moved target deletion of lowerToLoopsUsingSCFForOp to caller 

    The caller of function `lowerToLoopsUsingSCFForOp`, `ConvertToLoopsOp` was not deleting its
(structured) target op, resulting in IR with the expected loop nest in
front of the still remaining (structured) op, e.g. a linalg.matmul.
    @lhunloh
    lhunloh committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    4f6bd46 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Test deletion of structured op via transform.structured.convert_to_loops 

    This tests that the op is indeed deleted by
transform.structured.convert_to_loops.
    @lhunloh
    lhunloh committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    06b97fa View commit details
    Browse the repository at this point in the history