Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InstCombine] Fix infinite loop in select equivalence fold #84036

Merged
merged 1 commit into from
Mar 6, 2024

Commits on Mar 5, 2024

  1. [InstCombine] Fix infinite loop in select equivalence fold

    When replacing with a non-constant, it's possible that the result
    of the simplification is actually more complicated than the original,
    and may result in an infinite combine loop.
    
    Mitigate the issue by requiring that either the replacement or
    simplification result is constant, which should ensure that it's
    simpler. This is a very simple check that doesn't seem to cause
    many regressions in our own tests, so let's see if it's good
    enough.
    
    Fixes llvm#83127.
    nikic committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    611c898 View commit details
    Browse the repository at this point in the history