Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir][emitc] Fix emitc.expression example #84060

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[mlir][emitc] Fix emitc.expression example #84060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,17 +389,17 @@ def EmitC_ExpressionOp : EmitC_Op<"expression",

As the operation is to be emitted as a C expression, the operations within
its body must form a single Def-Use tree of emitc ops whose result is
yielded by a terminating `yield`.
yielded by a terminating `emitc.yield`.

Example:

```mlir
%r = emitc.expression : () -> i32 {
%r = emitc.expression : i32 {
%0 = emitc.add %a, %b : (i32, i32) -> i32
%1 = emitc.call "foo"(%0) : () -> i32
%1 = emitc.call_opaque "foo"(%0) : (i32) -> i32
%2 = emitc.add %c, %d : (i32, i32) -> i32
%3 = emitc.mul %1, %2 : (i32, i32) -> i32
yield %3
emitc.yield %3 : i32
}
```

Expand All @@ -409,9 +409,9 @@ def EmitC_ExpressionOp : EmitC_Op<"expression",
int32_t v7 = foo(v1 + v2) * (v3 + v4);
```

The operations allowed within expression body are emitc.add, emitc.apply,
emitc.call, emitc.cast, emitc.cmp, emitc.div, emitc.mul, emitc.rem and
emitc.sub.
The operations allowed within expression body are `emitc.add`,
`emitc.apply`, `emitc.call_opaque`, `emitc.cast`, `emitc.cmp`, `emitc.div`,
`emitc.mul`, `emitc.rem`, and `emitc.sub`.

When specified, the optional `do_not_inline` indicates that the expression is
to be emitted as seen above, i.e. as the rhs of an EmitC SSA value
Expand Down
Loading