[MLIR] Add missing MLIRDialectUtils dep to TilingInterface

[RoboTux]

This fixes the following failure when doing a clean build (in particular
no .ninja* lying around) of lib/libMLIRTilingInterface.a only:

In file included from mlir/include/mlir/Interfaces/TilingInterface.h:17,                                                                     
                 from mlir/lib/Interfaces/TilingInterface.cpp:13:                                                                            
mlir/include/mlir/Dialect/Utils/StructuredOpsUtils.h:27:10: fatal error: mlir/Dialect/Utils/DialectUtilsEnums.h.inc: No such file or directory

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Thomas Preud'homme (RoboTux)

Changes

This fixes a failure when doing a clean build of
lib/libMLIRDialectUtils.a only.

---

Full diff: https://github.com/llvm/llvm-project/pull/84544.diff

1 Files Affected:

• (modified) mlir/lib/Interfaces/CMakeLists.txt (+14-1)

diff --git a/mlir/lib/Interfaces/CMakeLists.txt b/mlir/lib/Interfaces/CMakeLists.txt
index e7c76e70ed6b5d..d3b7bf65ad3e73 100644
--- a/mlir/lib/Interfaces/CMakeLists.txt
+++ b/mlir/lib/Interfaces/CMakeLists.txt
@@ -101,7 +101,20 @@ add_mlir_library(MLIRSubsetOpInterface
   MLIRValueBoundsOpInterface
   )
 
-add_mlir_interface_library(TilingInterface)
+add_mlir_library(MLIRTilingInterface
+  TilingInterface.cpp
+
+  ADDITIONAL_HEADER_DIRS
+  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
+
+  DEPENDS
+  MLIRTilingInterfaceIncGen
+  MLIRDialectUtils
+
+  LINK_LIBS PUBLIC
+  MLIRIR
+)
+
 add_mlir_interface_library(VectorInterfaces)
 add_mlir_interface_library(ViewLikeInterface)
 

[RoboTux]

Ping?

[matthias-springer]

This change is problematic because it introduces a dependency from mlir/Interfaces on a dialect. (DialectUtils depends on ArithDialect.) I'd like to understand why TilingInterface needs DialectUtils. Do you see a way to remove that dependency?

[RoboTux]

This change is problematic because it introduces a dependency from mlir/Interfaces on a dialect. (DialectUtils depends on ArithDialect.) I'd like to understand why TilingInterface needs DialectUtils. Do you see a way to remove that dependency?

DialectUtils provide the IteratorType used in TilingInterface's getLoopIteratorTypes() return type(SmallVectorutils::IteratorType).

On the other hand AFAIK the ArithDialect dependency is only because of this line:
https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/Utils/StaticValueUtils.cpp#L25

(it also need an extra include of mlir/IR/Builders.h in StaticValueUtils.h and a MLIRDialectUtilsIncGen dependency in MLIRDialectUtils library definition). Could that somehow be made conditional upon ArithDialect being linked transitively or maybe moved to another place?

[matthias-springer]

If that's the only reason, we should be able to replace the implementation with a call to getConstantIntValue, which uses the matcher API. Then we won't rely on the Arith dialect anymore.

[RoboTux]

Perfect, I'll make a patch to dissociate UtilsDialect from ArithUtils.

[RoboTux]

Perfect, I'll make a patch to dissociate UtilsDialect from ArithUtils.

#85919