[libc++] Use clang-tidy version that matches the compiler we use in the CI #85305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he CI This works around ODR violations in the clang-tidy plugin we use to perform the modules tests. Fixes llvm#85242
ldionne
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesThis works around ODR violations in the clang-tidy plugin we use to perform the modules tests. Fixes #85242 Full diff: https://github.com/llvm/llvm-project/pull/85305.diff 1 Files Affected:
diff --git a/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt b/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt
index 978e7095216522..a52140e2b9938a 100644
--- a/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt
+++ b/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt
@@ -5,7 +5,7 @@
set(LLVM_DIR_SAVE ${LLVM_DIR})
set(Clang_DIR_SAVE ${Clang_DIR})
-find_package(Clang 18)
+find_package(Clang 18.1)
if (NOT Clang_FOUND)
find_package(Clang 17)
endif()
|
mordante
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
@tstellar due to the new LLVM version number scheme this code would mix LLVM 17 and LLVM 18. (LLVM 18.1 is not considered to be LLVM 18.) Since these are expected not to be ABI stable it seems we ran into ODR violations. For main I landed a different fix that has other improvements. These improvements should not be backported to LLVM-18. This is the minimal fix needed for LLVM-18.
LGTM!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around ODR violations in the clang-tidy plugin we use to perform the modules tests.
Fixes #85242