Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapply: [Float2Int] Resolve FIXME: Pick the smallest legal type that fits #86337

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Reapply: [Float2Int] Resolve FIXME: Pick the smallest legal type that fits #86337

merged 2 commits into from
Mar 25, 2024

Commits on Mar 22, 2024

  1. [Float2Int]: Pre-commit tests (NFC)

    @AreaZR
    AreaZR committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    c2cc25d View commit details
    Browse the repository at this point in the history

  2. Reapply: [Float2Int] Resolve FIXME: Pick the smallest legal type that… 

    … fits

Originally reverted because of a bug in Range that is now fixed, we can reland this commit. Tests have been added to ensure the miscompile that caused the revert does not happen again.
    @AreaZR
    AreaZR committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    413b8a4 View commit details
    Browse the repository at this point in the history