Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Codegen][X86] Fix /hotpatch with clang-cl and inline asm #87639

Merged
merged 2 commits into from
Apr 9, 2024
Merged

[Codegen][X86] Fix /hotpatch with clang-cl and inline asm #87639

merged 2 commits into from
Apr 9, 2024

Commits on Apr 4, 2024

  1. [Codegen][X86] Fix /hotpatch with clang-cl and inline asm 

    This fixes an edge case where functions starting with inline assembly would
assert while trying to lower that inline asm instruction.

After this commit, for now we always add 2 NOPs without considering the size
of the next inline asm instruction. We might want to revisit this in the
future.

This fixes Unreal Engine 5.3.2 compilation with clang-cl and /HOTPATCH.

Should close llvm#56234
    @aganea
    aganea committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    455c4e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Change nop for int3 in test

    @aganea
    aganea committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    29f40cb View commit details
    Browse the repository at this point in the history