Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/18.x: github-upload-release.py: Fix bug preventing release creation (#84571) #88425

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Apr 11, 2024

Backport 0b9ce71

Requested by: @tstellar

@llvmbot llvmbot added this to the LLVM 18.X Release milestone Apr 11, 2024
@llvmbot
Copy link
Collaborator Author

llvmbot commented Apr 11, 2024

@boomanaiden154 What do you think about merging this PR to the release branch?

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

…4571)

After aa02002 we started passing the
user name to the create_release function and this was being interpreted
as the git tag.

(cherry picked from commit 0b9ce71)
@tstellar tstellar merged commit c24b41d into llvm:release/18.x Apr 15, 2024
7 of 8 checks passed
rrbutani pushed a commit to bazel-contrib/toolchains_llvm that referenced this pull request May 8, 2024
After llvm/llvm-project#88425 seems to have been
resolved there is an `x86_64-linux-gnu-ubuntu` release for llvm 18.1.4
:tada:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants