Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++][ci] Removes C++2b selection option. #88557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mordante
Copy link
Member

Since Clang 16 is no longer supported all compilers support C++23.

@mordante mordante requested a review from a team as a code owner April 12, 2024 18:50
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Apr 12, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Apr 12, 2024

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

Changes

Since Clang 16 is no longer supported all compilers support C++23.


Full diff: https://github.com/llvm/llvm-project/pull/88557.diff

1 Files Affected:

  • (modified) libcxx/utils/libcxx/test/params.py (-6)
diff --git a/libcxx/utils/libcxx/test/params.py b/libcxx/utils/libcxx/test/params.py
index 5e42562ed5db52..5bc6e101c15420 100644
--- a/libcxx/utils/libcxx/test/params.py
+++ b/libcxx/utils/libcxx/test/params.py
@@ -79,12 +79,6 @@
 def getStdFlag(cfg, std):
     if hasCompileFlag(cfg, "-std=" + std):
         return "-std=" + std
-    # TODO(LLVM-19) Remove the fallbacks needed for Clang 16.
-    fallbacks = {
-        "c++23": "c++2b",
-    }
-    if std in fallbacks and hasCompileFlag(cfg, "-std=" + fallbacks[std]):
-        return "-std=" + fallbacks[std]
     return None
 
 

@mordante
Copy link
Member Author

It seems the Apple build bots still need this fallback option. So wait until the next Xcode release.

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we're able to have a green CI run (once we update Xcode).

@philnik777
Copy link
Contributor

@mordante this should be ready now, right?

Since Clang 16 is no longer supported all compilers support C++23.
@ldionne ldionne force-pushed the review/removes_clang_16_cxx23_version_selection branch from a750f0e to acbaac8 Compare September 16, 2024 20:47
@ldionne
Copy link
Member

ldionne commented Sep 16, 2024

Rebased onto main to give it a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants