Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeGen][i386] Move -mregparm storage earlier and fix Runtime calls #89707

Merged
merged 4 commits into from
Apr 29, 2024

Commits on Apr 23, 2024

  1. [CodeGen][i386] Move -mregparm storage earlier and fix Runtime calls

    When building the Linux kernel for i386, the -mregparm=3 option is
    enabled. Crashes were observed in the sanitizer handler functions,
    and the problem was found to be mismatched calling convention.
    
    As was fixed in commit c167c0a ("[BuildLibCalls] infer inreg param
    attrs from NumRegisterParameters"), call arguments need to be marked as
    "in register" when -mregparm is set. Use the same helper developed there
    to update the function arguments.
    
    Since CreateRuntimeFunction() is actually part of CodeGenModule, storage
    of the -mregparm value is also moved to the constructor, as doing this
    in Release() is too late.
    
    Fixes: llvm#89670
    kees committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c061c8f View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    b7abf7c View commit details
    Browse the repository at this point in the history
  2. Add comment to BuildLibCalls.h with a FIXME hint about where things a…

    …re fragile
    
    Signed-off-by: Kees Cook <keescook@chromium.org>
    kees committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b676440 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Configuration menu
    Copy the full SHA
    3107e76 View commit details
    Browse the repository at this point in the history