-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOLT,RISCV] Remove empty name special case from #68977 #90004
[BOLT,RISCV] Remove empty name special case from #68977 #90004
Conversation
Created using spr 1.3.5-bogner
Do we need to handle this special case to keep compatibility with older toolchains? |
BOLT's RISC-V port is pretty new. I hope that we don't keep such compatibility (old clang with new bolt)... |
I'm fine with removing the special case as long as @mtvec agrees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The premerge bot fails. The reason is that |
Let me look into that. It was done intentionally to reduce pre-merge builder load, but looks like there's no way around using trunk clang in BOLT testing. |
Should be fixed by 59bfc31 |
Thanks! |
The special case is unneeded after #89693.