release/18.x: [libclc] Fix linking against libIRReader #91553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illwieckz
changed the title
illwieckz
force-pushed
the
libclc-irreader-link
branch
3 times, most recently
from
604b95f
to
dcb8d6b
Compare
tstellar
force-pushed
the
libclc-irreader-link
branch
from
dcb8d6b
to
1665723
Compare
tstellar
approved these changes
May 15, 2024
|
@illwieckz (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91551:
prepare-builtins.cpp.o: undefined reference to symbol '_ZN4llvm7parseIRENS_15MemoryBufferRefERNS_12SMDiagnosticERNS_11LLVMContextENS_15ParserCallbacksE'#91551The patch is not needed in
mainbecause another larger patch already merged inmainincludes this change: 61efea7 .This one line patch is enough to fix the build on LLVM 18 branch so it's probably a good idea to merge it, it's obvious, non-intrusive and can't do harm.